From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYEIa-000797-Pp for qemu-devel@nongnu.org; Fri, 03 May 2013 07:37:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYEIW-0004DH-OU for qemu-devel@nongnu.org; Fri, 03 May 2013 07:37:12 -0400 Message-ID: <5183A13B.2030108@web.de> Date: Fri, 03 May 2013 13:36:27 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1367525344-7755-1-git-send-email-hpoussin@reactos.org> <1367525344-7755-8-git-send-email-hpoussin@reactos.org> In-Reply-To: <1367525344-7755-8-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH 7/7] prep: QOM'ify System I/O List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= Cc: Julio Guerra , qemu-ppc@nongnu.org, qemu-devel@nongnu.org Am 02.05.2013 22:09, schrieb Hervé Poussineau: > Most of the functionality is extracted from hw/ppc/prep.c. > Also add support for board identification/equipment registers. > > Document it for the IBM 43p emulation. > > Cc: Julio Guerra > Signed-off-by: Hervé Poussineau > --- > docs/ibm_43p.cfg | 5 + > hw/ppc/Makefile.objs | 1 + > hw/ppc/prep_systemio.c | 298 ++++++++++++++++++++++++++++++++++++++++++++++++ > trace-events | 4 + > 4 files changed, 308 insertions(+) > create mode 100644 hw/ppc/prep_systemio.c Haven't reviewed the full patch yet, but since this is not modifying hw/ppc/prep.c, it is duplicating code rather than QOM'ifying the existing code. Have you looked into Julio's patch whom you CC? I'm still not sure how to solve things for 1.5 (and this series a consider -next). Regards, Andreas