From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: "Jon Arne Jørgensen" <jonarne@jonarne.no>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-media@vger.kernel.org, jonjon.arnearne@gmail.com
Subject: Re: [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function
Date: Fri, 03 May 2013 08:37:15 -0300 [thread overview]
Message-ID: <5183A16B.8050807@redhat.com> (raw)
In-Reply-To: <20130503063228.GB1232@dell.arpanet.local>
Em 03-05-2013 03:32, Jon Arne Jørgensen escreveu:
> On Thu, May 02, 2013 at 11:09:14PM -0300, Ezequiel Garcia wrote:
>> Hi Jon,
>>
>> On Mon, Apr 29, 2013 at 10:41:07PM +0200, Jon Arne Jørgensen wrote:
>>> As we're now seeing other variants from chinese clones, like
>>> gm1113c, we'll need to add more bits at the detection code.
>>>
>>> So, move it into a separate function.
>>>
>>> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>> Signed-off-by: Jon Arne Jørgensen <jonarne@jonarne.no>
>>
>> As far as I can see, this patch is identical to the one sent
>> by Mauro. Therefore, your SOB here is incorrect, since you are not
>> the author of the patch.
>>
>> The proper way of re-submitting patches that have been previously
>> submitted by another developer is this:
>>
>> --
>> From: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>> Commit message goes here.
>>
>> Notice how the first line is a 'From:' tagcindicating who's the
>> real submitter. The SOB tag indicates the patch author, and you
>> can add your acked-by, tested-by or reported-by if you want.
>>
>> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>> Reported-by: Jon Arne Jørgensen <jonarne@jonarne.no>
Please also add here your Tested-by: if you tested (very likely
you did it). The same applies to patch 2/3.
>> --
>>
>> You can read more about this in Documentation/SubmittingPatches.
>
> Ok, I'll fix this
Regards,
Mauro.
next prev parent reply other threads:[~2013-05-03 11:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 20:41 [PATCH 0/3] saa7115: add detection code for gm7113c Jon Arne Jørgensen
2013-04-29 20:41 ` [PATCH V2 1/3] saa7115: move the autodetection code out of the probe function Jon Arne Jørgensen
2013-05-03 2:09 ` Ezequiel Garcia
2013-05-03 6:32 ` Jon Arne Jørgensen
2013-05-03 11:37 ` Mauro Carvalho Chehab [this message]
2013-05-03 6:58 ` Jon Arne Jørgensen
2013-05-03 11:20 ` Ezequiel Garcia
2013-05-03 12:08 ` Mauro Carvalho Chehab
2013-05-05 8:20 ` Jon Arne Jørgensen
2013-05-05 11:29 ` Mauro Carvalho Chehab
2013-04-29 20:41 ` [PATCH V2 2/3] saa7115: add detection code for gm7113c Jon Arne Jørgensen
2013-05-03 2:10 ` Ezequiel Garcia
2013-04-29 20:41 ` [PATCH V2 3/3] saa7115: Add register setup and config " Jon Arne Jørgensen
2013-05-03 2:24 ` Ezequiel Garcia
2013-05-03 6:35 ` Jon Arne Jørgensen
2013-05-03 2:00 ` [PATCH 0/3] saa7115: add detection code " Ezequiel Garcia
2013-05-03 6:27 ` Jon Arne Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5183A16B.8050807@redhat.com \
--to=mchehab@redhat.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=jonarne@jonarne.no \
--cc=jonjon.arnearne@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.