All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rich Johnston <rjohnston@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfstests shared/298: various fixes
Date: Fri, 3 May 2013 08:00:41 -0500	[thread overview]
Message-ID: <5183B4F9.2000008@sgi.com> (raw)
In-Reply-To: <517FF548.1010309@sandeen.net>

On 04/30/2013 11:46 AM, Eric Sandeen wrote:
> fix shared/298:
>
> * don't include common/config, not needed and breaks
>    stuff when $SCRATCH_DEV_POOL is defined:
>      Error: $SCRATCH_DEV should be unset when $SCRATCH_DEV_POOL is set
> * make sure xfs_io has fiemap, we'll need it
> * add -F to the xfs_io invocation, again, for use on
>    old xfsprogs on non-xfs filesystems
> * ignore ENOSPC errors from "garbage" loop; the only goal
>    is to fill it, ENOSPC doesn't matter.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
> ---
>
> V2: break out of copy loop when full

Dave, looks like Eric applied your suggestions, may I put your 
Reviewed-by on this one?


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-05-03 13:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 20:18 [PATCH] xfstests shared/298: various fixes Eric Sandeen
2013-04-30  7:43 ` Dave Chinner
2013-04-30 14:17   ` Eric Sandeen
2013-04-30 16:46 ` [PATCH V2] " Eric Sandeen
2013-05-03 13:00   ` Rich Johnston [this message]
2013-05-14 18:15   ` Rich Johnston
2013-05-14 18:18   ` Rich Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5183B4F9.2000008@sgi.com \
    --to=rjohnston@sgi.com \
    --cc=sandeen@redhat.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.