From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sasha Levin Subject: Re: [RFC PATCH 04/11] kvm tools: console: unconditionally output to any console Date: Fri, 03 May 2013 12:02:14 -0400 Message-ID: <5183DF86.3040507@oracle.com> References: <1367423416-24640-1-git-send-email-will.deacon@arm.com> <1367423416-24640-5-git-send-email-will.deacon@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Will Deacon , Asias He , KVM General , Marc Zyngier , anup@brainfault.org, Rusty Russell , pranavkumar@linaro.org, Michael Ellerman To: Pekka Enberg Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:49423 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933207Ab3ECQCx (ORCPT ); Fri, 3 May 2013 12:02:53 -0400 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 05/03/2013 05:19 AM, Pekka Enberg wrote: > On Wed, May 1, 2013 at 6:50 PM, Will Deacon wrote: >> From: Marc Zyngier >> >> Kvmtool suppresses any output to a console that has not been elected >> as *the* console. >> >> While this makes sense on the input side (we want the input to be sent >> to one console driver only), it seems to be the wrong thing to do on >> the output side, as it effectively prevents the guest from switching >> from one console to another (think earlyprintk using 8250 to virtio >> console). >> >> After all, the guest *does* poke this device and outputs something >> there. >> >> Just remove the kvm->cfg.active_console test from the output paths. >> >> Signed-off-by: Marc Zyngier >> Signed-off-by: Will Deacon > > Seems reasonable. Asias, Sasha? > I remember at trying it some time ago but dropped it for a reason I don't remember at the moment. Can I have the weekend to play with it to try and figure out why? Thanks, Sasha