From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41287)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1UYUxS-0008Vo-NA
	for qemu-devel@nongnu.org; Sat, 04 May 2013 01:24:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hpoussin@reactos.org>) id 1UYUxR-0006SD-Bl
	for qemu-devel@nongnu.org; Sat, 04 May 2013 01:24:30 -0400
Message-ID: <51849B7F.8020208@reactos.org>
Date: Sat, 04 May 2013 07:24:15 +0200
From: =?ISO-8859-1?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>
MIME-Version: 1.0
References: <1367525344-7755-1-git-send-email-hpoussin@reactos.org>
	<1367525344-7755-5-git-send-email-hpoussin@reactos.org>
	<CACXAS8AsWY3s7eKzuafBh_E-WCWJnudWFTphasPMYLigS8snAA@mail.gmail.com>
	<5183502A.3070800@reactos.org>
	<CACXAS8AQmbjd-+mHb72xN2R5BJwDx5gwsJy4d9eWdYpaDfCDvA@mail.gmail.com>
In-Reply-To: <CACXAS8AQmbjd-+mHb72xN2R5BJwDx5gwsJy4d9eWdYpaDfCDvA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 4/7] m48t59: register a QOM type for each
 nvram type we support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Artyom Tarasenko <atar4qemu@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-ppc@nongnu.org, qemu-devel <qemu-devel@nongnu.org>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>

Artyom Tarasenko a =E9crit :
> On Fri, May 3, 2013 at 7:50 AM, Herv=E9 Poussineau <hpoussin@reactos.or=
g> wrote:
>> Artyom Tarasenko a =E9crit :
>>
>>> On Thu, May 2, 2013 at 10:09 PM, Herv=E9 Poussineau <hpoussin@reactos=
.org>
>>> wrote:
>>>> As m48t59 devices can only be created with m48t59_init() or
>>>> m48t59_init_isa(),
>>>> we know exactly which nvram types are required. Register only those =
three
>>>> types.
>>>
>>> Wasn't this patch NACKed by Blue?
>>
>> I think I changed what's requested, ie I kept the io-base property of =
the
>> ISA variant, so the sun4u emulation can be changed later to the right
>> address. However, fixing sun4u emulation is not part of this patchset.
>=20
> Sorry, I misread the patch. The value 0x74 is now just a default value =
for
> the isa port, right? How would I create an isa m48t59 card on some othe=
r port?

Yes, 0x74 is now the default value.

You can create an isa m48t59 device on port 0x100
- with command line: -device isa-m4859,iobase=3D0x100
- in code using the helper: m48t59_init_isa(isa_bus, 0x100, 0x2000, 59);
- with QOM: DeviceState *dev;
             dev =3D DEVICE(isa_create(isa_bus, "isa-m48t59"));
             qdev_prop_set_uint16(dev, "iobase", 0x100);
             qdev_init_nofail(dev);

Herv=E9