From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37662) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYXVx-0006Xx-D0 for qemu-devel@nongnu.org; Sat, 04 May 2013 04:08:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYXVw-00017P-57 for qemu-devel@nongnu.org; Sat, 04 May 2013 04:08:17 -0400 Received: from mout.web.de ([212.227.15.4]:59341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYXVv-00017L-Rm for qemu-devel@nongnu.org; Sat, 04 May 2013 04:08:16 -0400 Message-ID: <5184C1EE.7050305@web.de> Date: Sat, 04 May 2013 10:08:14 +0200 From: Jan Kiszka MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2XLGSLVJECHCVKCVLHBNH" Subject: Re: [Qemu-devel] Patch of consistent VMX cpu flag List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?IuadjuaYpeWlhyA8QXJ0aHVyIENodW5xaSBMaT4i?= Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2XLGSLVJECHCVKCVLHBNH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2013-05-04 09:59, =E6=9D=8E=E6=98=A5=E5=A5=87 wrote= : > Hi all, > There's a patch for some simulated Intel CPU with default flag of VMX, = now > only core(2)duo are with VMX flag by default. >=20 > Add default ext_features of CPUID_EXT_VMX to the following CPUs: > kvm64, kvm32, Penryn, Nehalem, Westmere, SandyBridge, Haswell. >=20 > Other CPUs of AMD and lower versions of Intel CPU without VMX support d= on't > add this feature by default. >=20 > Patch: Please have a look at http://wiki.qemu.org/Contribute/SubmitAPatch regarding how to format a patch. Moreover, your mail client had line-wrapping enabled which ruins the patch. And you are sending mixed plain/html mails, but only plain-text is acceptable. Jan >=20 > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index e2302d8..7b659f7 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -490,7 +490,7 @@ static x86_def_t builtin_x86_defs[] =3D { > CPUID_MTRR | CPUID_CLFLUSH | CPUID_MCA | > CPUID_PSE36, > /* Missing: CPUID_EXT_POPCNT, CPUID_EXT_MONITOR */ > - .ext_features =3D CPUID_EXT_SSE3 | CPUID_EXT_CX16, > + .ext_features =3D CPUID_EXT_SSE3 | CPUID_EXT_CX16 | CPUID_EXT_= VMX, > /* Missing: CPUID_EXT2_PDPE1GB, CPUID_EXT2_RDTSCP */ > .ext2_features =3D (PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES) | > CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX, > @@ -522,7 +522,7 @@ static x86_def_t builtin_x86_defs[] =3D { > .stepping =3D 1, > .features =3D PPRO_FEATURES | > CPUID_MTRR | CPUID_CLFLUSH | CPUID_MCA | CPUID_PSE36, > - .ext_features =3D CPUID_EXT_SSE3, > + .ext_features =3D CPUID_EXT_SSE3 | CPUID_EXT_VMX, > .ext2_features =3D PPRO_FEATURES & CPUID_EXT2_AMD_ALIASES, > .ext3_features =3D 0, > .xlevel =3D 0x80000008, > @@ -648,7 +648,7 @@ static x86_def_t builtin_x86_defs[] =3D { > CPUID_MCE | CPUID_PAE | CPUID_MSR | CPUID_TSC | CPUID_PSE= | > CPUID_DE | CPUID_FP87, > .ext_features =3D CPUID_EXT_SSE41 | CPUID_EXT_CX16 | CPUID_EXT= _SSSE3 > | > - CPUID_EXT_SSE3, > + CPUID_EXT_SSE3 | CPUID_EXT_VMX, > .ext2_features =3D CPUID_EXT2_LM | CPUID_EXT2_NX | > CPUID_EXT2_SYSCALL, > .ext3_features =3D CPUID_EXT3_LAHF_LM, > .xlevel =3D 0x8000000A, > @@ -667,7 +667,7 @@ static x86_def_t builtin_x86_defs[] =3D { > CPUID_MCE | CPUID_PAE | CPUID_MSR | CPUID_TSC | CPUID_PSE= | > CPUID_DE | CPUID_FP87, > .ext_features =3D CPUID_EXT_POPCNT | CPUID_EXT_SSE42 | > CPUID_EXT_SSE41 | > - CPUID_EXT_CX16 | CPUID_EXT_SSSE3 | CPUID_EXT_SSE3, > + CPUID_EXT_CX16 | CPUID_EXT_SSSE3 | CPUID_EXT_SSE3 | > CPUID_EXT_VMX, > .ext2_features =3D CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | > CPUID_EXT2_NX, > .ext3_features =3D CPUID_EXT3_LAHF_LM, > .xlevel =3D 0x8000000A, > @@ -687,7 +687,7 @@ static x86_def_t builtin_x86_defs[] =3D { > CPUID_DE | CPUID_FP87, > .ext_features =3D CPUID_EXT_AES | CPUID_EXT_POPCNT | CPUID_EXT= _SSE42 > | > CPUID_EXT_SSE41 | CPUID_EXT_CX16 | CPUID_EXT_SSSE3 | > - CPUID_EXT_PCLMULQDQ | CPUID_EXT_SSE3, > + CPUID_EXT_PCLMULQDQ | CPUID_EXT_SSE3 | CPUID_EXT_VMX, > .ext2_features =3D CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | > CPUID_EXT2_NX, > .ext3_features =3D CPUID_EXT3_LAHF_LM, > .xlevel =3D 0x8000000A, > @@ -709,7 +709,7 @@ static x86_def_t builtin_x86_defs[] =3D { > CPUID_EXT_TSC_DEADLINE_TIMER | CPUID_EXT_POPCNT | > CPUID_EXT_X2APIC | CPUID_EXT_SSE42 | CPUID_EXT_SSE41 | > CPUID_EXT_CX16 | CPUID_EXT_SSSE3 | CPUID_EXT_PCLMULQDQ | > - CPUID_EXT_SSE3, > + CPUID_EXT_SSE3 | CPUID_EXT_VMX, > .ext2_features =3D CPUID_EXT2_LM | CPUID_EXT2_RDTSCP | CPUID_E= XT2_NX > | > CPUID_EXT2_SYSCALL, > .ext3_features =3D CPUID_EXT3_LAHF_LM, > @@ -733,7 +733,7 @@ static x86_def_t builtin_x86_defs[] =3D { > CPUID_EXT_SSE41 | CPUID_EXT_CX16 | CPUID_EXT_SSSE3 | > CPUID_EXT_PCLMULQDQ | CPUID_EXT_SSE3 | > CPUID_EXT_TSC_DEADLINE_TIMER | CPUID_EXT_FMA | > CPUID_EXT_MOVBE | > - CPUID_EXT_PCID, > + CPUID_EXT_PCID | CPUID_EXT_VMX, > .ext2_features =3D CPUID_EXT2_LM | CPUID_EXT2_RDTSCP | CPUID_E= XT2_NX > | > CPUID_EXT2_SYSCALL, > .ext3_features =3D CPUID_EXT3_LAHF_LM, >=20 ------enig2XLGSLVJECHCVKCVLHBNH Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlGEwe4ACgkQitSsb3rl5xRo+wCfYq2XwMSH0+bAqlV/61pTUJTZ TbkAoLHf1of2MAJa1niBciR+esk42rQd =WNBT -----END PGP SIGNATURE----- ------enig2XLGSLVJECHCVKCVLHBNH--