From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2 v12] Introduced btrfs file-system with btrload command
Date: Sun, 5 May 2013 10:52:46 -0400 [thread overview]
Message-ID: <5186723E.2080503@ti.com> (raw)
In-Reply-To: <20130505072819.5DDBA380E6C@gemini.denx.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 05/05/2013 03:28 AM, Wolfgang Denk wrote:
> Dear Adnan Ali,
>
> In message <1367660512-10489-3-git-send-email-adnan9901@yahoo.com>
> you wrote:
>
> ... include/crc.h | 8 + include/fs.h
> | 1 + lib/Makefile | 1 + lib/crc32_c.c
> | 40 ++ ...
>
> These changes should be factored out into a separate commit. In any
> case, the code should be compiled in only when needed, i. e. when
> btrfs support is selected. Otherwise you just bloat the code size
> and build time for all systems without need.
We should be able to make lib/crc32_c.o depend on btrfs being set,
yes. But non-command stuff should be getting garbage collected out in
most cases at last (Need to poke Albert about the patch for ARM).
> Hm... do we really need yet another crc32 implementation?
We talked about this before I believe and the answer is yes :(
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
iQIcBAEBAgAGBQJRhnI+AAoJENk4IS6UOR1WGRMP/inIOtRRDrzuKuUOtiykWTGr
XtlODIrJNvWmXz3Vzs3zle8LhuwvCtUUs0WaXOi1VBVCCOt6fsqGjcbWYtRvfwvo
PtCUfyrJE+dA+pv2UFO+vwqBJoY1ew7ehjfrl0Z9JaO5AphXyPvcxtiRHsUDRbG+
NwGgv2RiYtH8WLzxCBAV2kXsE7HXCkHbloj/kLDah/X3fXDBQ8X+OKNkSOsgs85l
xg0HStiPbYkqrM+dLsCyd5/YEj9aXmlGa7g7amPAxHOC7lmFRaxI16uDw8p0hW/n
BrNHyE8F3acf1tTKGAyJYvVPd9Z4icUjBU/XkXDLr9tVp1GGDJ5pcWe80//AFy+S
3LQcPul3+6yqdBks5zSTNMBmUYqOceRzhJSpsDp1c7x6uMNsB3kOauoQ/UEiCitz
fn+CJND11A3fEF6XsOvzLUqw7BFnd5g7bIDXmX1Rq18tY6wwMQsZMl1jPvHkEP+R
Q0SdKwsXQcuKDMgCk0pLRzuiPNd/t/PQttuRPNG/wJegFN+L+Ers4PPwc73/km5S
4aINFzTmc2NMxUgsswk/xGeKt3fE3cvrTn2v3PR2vOPqcv76v8+CKtix8hEYF6eS
m5x2KJpQho9eno8VFTp52bU+zYy67mJ2k8UfWY5Ist8YG7koHtIKQIuZmGf9XMu4
RV6SbpltW+2hCcvDGHvd
=Lj6s
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2013-05-05 14:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-04 9:41 [U-Boot] [PATCH 0/2 v12] Btrfs filesystem port to U-boot Adnan Ali
2013-05-04 9:41 ` [U-Boot] [PATCH 1/2 v12] Enable Btrfs support in mx53loco config Adnan Ali
2013-05-04 9:41 ` [U-Boot] [PATCH 2/2 v12] Introduced btrfs file-system with btrload command Adnan Ali
2013-05-05 7:28 ` Wolfgang Denk
2013-05-05 14:52 ` Tom Rini [this message]
2013-05-05 15:15 ` Wolfgang Denk
2013-05-09 14:55 ` Adnan Ali
2013-05-09 21:43 ` Wolfgang Denk
2013-05-12 12:00 ` Adnan Ali
2013-05-12 18:20 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5186723E.2080503@ti.com \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.