Re: [PATCH 1/3] Input: altera_ps2 - Remove redundant platform_set_drvdata()

[Thomas Chou <thomas@wytron.com.tw>]

Hi Sachin,

On 05/03/2013 06:36 PM, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> Cc: Thomas Chou <thomas@wytron.com.tw>
> ---
>   drivers/input/serio/altera_ps2.c |    1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/input/serio/altera_ps2.c b/drivers/input/serio/altera_ps2.c
> index 479ce5f..a0a2657 100644
> --- a/drivers/input/serio/altera_ps2.c
> +++ b/drivers/input/serio/altera_ps2.c
> @@ -163,7 +163,6 @@ static int altera_ps2_remove(struct platform_device *pdev)
>   {
>   	struct ps2if *ps2if = platform_get_drvdata(pdev);
>
> -	platform_set_drvdata(pdev, NULL);
>   	serio_unregister_port(ps2if->io);
>   	free_irq(ps2if->irq, ps2if);
>   	iounmap(ps2if->base);
>

Acked-by: Thomas Chou <thomas@wytron.com.tw>

Thanks.
- Thomas