Re: [RFCv2 PATCH 2/9] v4l: vb2-dma-contig: update and code refactoring

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Tomasz,

Thanks for the patch.

On Tuesday 13 March 2012 11:17:00 Tomasz Stanislawski wrote:
> This patch combines updates and fixes to dma-contig allocator.
> Moreover the allocator code was refactored.
> The most important changes are:
> - functions were reordered
> - move compression of scatterlist to separete function
> - add support for multichunk but contiguous scatterlists
> - simplified implementation of vb2-dma-contig context structure
> - let mmap method to use dma_mmap_writecombine
> - add support for scatterlist in userptr mode

Combining all this makes it pretty difficult to review the patch. What about 
splitting the patch into the following ?

- Function rename (s/vb2_dma_contig_/vb2_dc_/)
- Code reordering
- Replace custom alloc_ctx structure with direct struct device usage
- The rest, possibly further split into MMAP and USERPTR changes

That would make the patch easier to review. I've already split it according to 
the above (with the MMAP and USERPTR changes kept together as the original 
patch). I'll post the patches in reply to this mail, with my comments as 
further replies.

-- 
Regards,

Laurent Pinchart