All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Liu <jeff.liu@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: xfs@oss.sgi.com, dchinner@redhat.com
Subject: Re: xfs: add buffer types to directory and attribute buffers
Date: Mon, 06 May 2013 17:27:25 +0800	[thread overview]
Message-ID: <5187777D.7010802@oracle.com> (raw)
In-Reply-To: <20130506091116.GA2129@elgon.mountain>

On 05/06/2013 05:11 PM, Dan Carpenter wrote:
> Hello Dave Chinner,
> 
> The patch d75afeb3d302: "xfs: add buffer types to directory and 
> attribute buffers" from Apr 3, 2013, leads to the following Smatch warning:
> "fs/xfs/xfs_log_recover.c:2042 xlog_recovery_validate_buf_type()
> 	 warn: always true condition '(magicda != 1480675917) =>  (0-u16max != 1480675917)'"
> 
> fs/xfs/xfs_log_recover.c
>   2039          case XFS_BLFT_ATTR_RMT_BUF:
>   2040                  if (!xfs_sb_version_hascrc(&mp->m_sb))
>   2041                          break;
>   2042                  if (magicda != XFS_ATTR3_RMT_MAGIC) {
>                             ^^^^^^^
> This is an unsigned short so it can never be equal to 0x5841524d.  Was
> "magic32" intended here?
You are right, but this issue has been fixed by:

commit cab09a81fbefcb21db5213a84461d421946f6eb8
Author: Dave Chinner <dchinner@redhat.com>
Date:   Tue Apr 30 21:39:36 2013 +1000

    xfs: fix da node magic number mismatches

It has been discussed on following thread before:
http://oss.sgi.com/archives/xfs/2013-04/msg00645.html

Thanks,
-Jeff
> 
>   2043                          xfs_warn(mp, "Bad attr remote magic!");
>   2044                          ASSERT(0);
>   2045                          break;
>   2046                  }
>   2047                  bp->b_ops = &xfs_attr3_rmt_buf_ops;
>   2048                  break;
> 
> regards,
> dan carpenter
> 
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2013-05-06  9:27 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06  9:11 xfs: add buffer types to directory and attribute buffers Dan Carpenter
2013-05-06  9:27 ` Jeff Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5187777D.7010802@oracle.com \
    --to=jeff.liu@oracle.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dchinner@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.