From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46484)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UZMbD-0002iW-Nv
	for qemu-devel@nongnu.org; Mon, 06 May 2013 10:41:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UZMb9-00020n-4d
	for qemu-devel@nongnu.org; Mon, 06 May 2013 10:41:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47739)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UZMb8-000205-T5
	for qemu-devel@nongnu.org; Mon, 06 May 2013 10:41:03 -0400
Message-ID: <5187C0ED.4030400@redhat.com>
Date: Mon, 06 May 2013 16:40:45 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1367849167.git.jan.kiszka@siemens.com>
	<2a270b2aed38f019865f66dfa902f31cf7f36276.1367849167.git.jan.kiszka@siemens.com>
In-Reply-To: <2a270b2aed38f019865f66dfa902f31cf7f36276.1367849167.git.jan.kiszka@siemens.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC][PATCH 12/15] vmware-vga: Accept unaligned
	I/O accesses
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Liu Ping Fan <pingfank@linux.vnet.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, =?ISO-8859-15?Q?Andreas_F=E4rbe?= =?ISO-8859-15?Q?r?= <afaerber@suse.de>

Il 06/05/2013 16:26, Jan Kiszka ha scritto:
> Before switching to the memory core dispatcher, we need to make sure
> that this pv-device will continue to receive unaligned portio accesses.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  hw/display/vmware_vga.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
> index fd3569d..ec41681 100644
> --- a/hw/display/vmware_vga.c
> +++ b/hw/display/vmware_vga.c
> @@ -1241,6 +1241,10 @@ static const MemoryRegionOps vmsvga_io_ops = {
>      .valid = {
>          .min_access_size = 4,
>          .max_access_size = 4,
> +        .unaligned = true,
> +    },
> +    .impl = {
> +        .unaligned = true,
>      },
>  };
>  
> 

The Xen platform device needs the same.

Paolo