Re: [Qemu-devel] [RFC][PATCH 12/15] vmware-vga: Accept unaligned I/O accesses

[Jan Kiszka <jan.kiszka@siemens.com>]

On 2013-05-06 16:40, Paolo Bonzini wrote:
> Il 06/05/2013 16:26, Jan Kiszka ha scritto:
>> Before switching to the memory core dispatcher, we need to make sure
>> that this pv-device will continue to receive unaligned portio accesses.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>>  hw/display/vmware_vga.c |    4 ++++
>>  1 files changed, 4 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c
>> index fd3569d..ec41681 100644
>> --- a/hw/display/vmware_vga.c
>> +++ b/hw/display/vmware_vga.c
>> @@ -1241,6 +1241,10 @@ static const MemoryRegionOps vmsvga_io_ops = {
>>      .valid = {
>>          .min_access_size = 4,
>>          .max_access_size = 4,
>> +        .unaligned = true,
>> +    },
>> +    .impl = {
>> +        .unaligned = true,
>>      },
>>  };
>>  
>>
> 
> The Xen platform device needs the same.

OK, good to know. In theory, this should only affect weird PV, so I hope
that is all.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux