From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49174)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1UZO0D-0005au-Jr
	for qemu-devel@nongnu.org; Mon, 06 May 2013 12:11:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <andreas.faerber@web.de>) id 1UZO0B-0001Gd-U7
	for qemu-devel@nongnu.org; Mon, 06 May 2013 12:11:01 -0400
Message-ID: <5187D609.2000207@web.de>
Date: Mon, 06 May 2013 18:10:49 +0200
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <andreas.faerber@web.de>
MIME-Version: 1.0
References: <1367775900-29706-1-git-send-email-andreas.faerber@web.de>
	<56170A62-0C96-458B-87B4-0C29F1CD4AE1@suse.de>
	<5186AC5A.3020908@web.de> <51876208.1020004@adacore.com>
In-Reply-To: <51876208.1020004@adacore.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH prep for-1.5 v2] prep: Add ELF support for
	-bios
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fabien Chouteau <chouteau@adacore.com>
Cc: PReP <qemu-ppc@nongnu.org>, "hpoussin@reactos.org" <hpoussin@reactos.org>, Alexander Graf <agraf@suse.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

Am 06.05.2013 09:55, schrieb Fabien Chouteau:
> On 05/05/2013 09:00 PM, Andreas Färber wrote:
>> Am 05.05.2013 20:40, schrieb Alexander Graf:
>>>
>>>
>>> Am 05.05.2013 um 19:45 schrieb Andreas Färber <andreas.faerber@web.de>:
>>>
>>>> This prepares for switching from OpenHack'Ware to OpenBIOS.
>>>>
>>>> While touching the error handling code, switch from aborting hw_error()
>>>> to fprintf()+exit() and suppress failing without -bios for qtest.
>>>>
>>>> Signed-off-by: Andreas Färber <andreas.faerber@web.de>
>>>
>>> Acked-by: Alexander Graf <agraf@suse.de>
>>
>> Thanks, applied to prep-up:
>> http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/prep-up
>>
>> Sorry, forgot the changelog:
>> * error handling was split up as suggested by Alex,
>> * missing exit(1) calls were added and
> 
> BTW, why do you use fprintf()+exit() instead of hw_error()?

That error is triggered by the user specifying a wrong -bios argument,
so we should fail gracefully (similar discussion about -m a while back)
and the CPU states are not so interesting at that point.

Andreas