From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZOGq-00065O-3y for qemu-devel@nongnu.org; Mon, 06 May 2013 12:28:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZOGo-0006nd-VW for qemu-devel@nongnu.org; Mon, 06 May 2013 12:28:11 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35500 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZOGo-0006nT-NL for qemu-devel@nongnu.org; Mon, 06 May 2013 12:28:10 -0400 Message-ID: <5187DA17.3090401@suse.de> Date: Mon, 06 May 2013 18:28:07 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1366657220-776-1-git-send-email-ehabkost@redhat.com> <1366657220-776-8-git-send-email-ehabkost@redhat.com> <5183D167.9010808@redhat.com> In-Reply-To: <5183D167.9010808@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 7/9] target-i386: Use FeatureWord loop on filter_features_for_kvm() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Eduardo Habkost Cc: libvir-list@redhat.com, Igor Mammedov , Jiri Denemark , qemu-devel@nongnu.org -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Am 03.05.2013 17:01, schrieb Eric Blake: > On 04/22/2013 01:00 PM, Eduardo Habkost wrote: >> Instead of open-coding the filtering code for each feature word, >> change the existing code to use the feature_word_info array, that >> have exactly the same CPUID eax/ecx/register values for each >> feature word. >>=20 >> Signed-off-by: Eduardo Habkost ---=20 >> target-i386/cpu.c | 24 +++++++----------------- 1 file changed, 7 >> insertions(+), 17 deletions(-) >>=20 >=20 >> + for (w =3D 0; w < FEATURE_WORDS; w++) { + >> FeatureWordInfo *wi =3D &feature_word_info[w]; + >> env->features[w] &=3D kvm_arch_get_supported_cpuid(s, >> wi->cpuid_eax, + >> wi->cpuid_ecx, + >> wi->cpuid_reg); >=20 > Indentation is unusual, but the resulting alignment is nicer than > having 'wi->' flush under 's'. I would have written the call in > four lines instead of 3, but that's not essential. >=20 > Reviewed-by: Eric Blake Thanks, applied to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu Andreas - --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRh9oXAAoJEPou0S0+fgE/oksP/1SKyK1oTJs9l7GG5atYxav7 7bDM/Pf4wTx63vs19XmvoaKCBBHYVhxM8RhXYRBFn1SHQhiXiJmgTpNDTpE9L+yq CpoXTyL/oReB32cUEeZYBjYWdG62IV8Ci09+FUhhmf4cduBQTXFV7i5jq/9IDooi fMUoksVGHeLOHvsUPFp3OSlO24KRCO0z/w8O74/fPzdrmrz3cMRxy7V59/ZHsNPg lAkXiFu56whYcA62A76HvRW200P75I8BuLq7NCPffFwMf9/N6eba7Wep0J1xnzpG GkXB7swuOENKRVPbZ6XKrCIAH96kk6WbJaXPrPplP6jATXhhuChlyyskrEz++hne XjjFAGOLFGrLuD+3eIB4VZ509GE+hUfyAG6JQWf+7BG20scepvsOgaPT/rvNyDjN LQnL/BJoV1+s4YKuZCIv3km/WQ76oNRNSlmA+R+KKCEfjOsl8Byg3L6/YSE4TaPs RiNXZTh0HkcyMzTYNdEOcxZcpW0G77jRAV7L3fMPd0TMixY8oKsqW4wg9pvZodLg yeCRn1N+op9HDj9W9qAq8IXwJiuLEKpCu2hqzVpYJRxws7ZAo7tfI5+ym1AMj4FZ pEb87EXqEqESzeWJS4XJZxaPw14WaWInWkNXhdq0J3J78UkB2pHnvAr2dDL9FvPx 9o6UzZiavkgcd860Im4J =3D4ouF -----END PGP SIGNATURE-----