From: Tony Asleson <tasleson@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH] lvm2app: Add thin and thin pool lv creation V2
Date: Mon, 06 May 2013 12:17:23 -0500 [thread overview]
Message-ID: <5187E5A3.3090300@redhat.com> (raw)
In-Reply-To: <5187D093.7080105@gmail.com>
On 05/06/2013 10:47 AM, Zdenek Kabelac wrote:
> We already have the API 'explosion' for lvs/pvs/vgs properties.
> So I think it could probably share the same principal for lvcreate attrs.
For API consistency we probably should use the same technique for
get/set proprieties like we do in other parts of the API, for some
reason when you mentioned more C++ like I went with a separate get/set
functions. I've mentioned before that I don't like returning structures
by value because there is a potential link issues if the library and
client code compiled with different options:
-fpcc-struct-return/-freg-struct-return.
> I liked the 'X protocol' way of using string named fields - but then
> you lose compile time check whether you pass valid arguments...
We are going to lose compile time enforcement regardless if we want
generic get/set functionality.
Regards,
Tony
next prev parent reply other threads:[~2013-05-06 17:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 16:08 [PATCH] lvm2app: Add thin and thin pool lv creation V2 Tony Asleson
2013-05-06 13:26 ` M. Mohan Kumar
2013-05-06 15:37 ` Tony Asleson
2013-05-06 15:47 ` Zdenek Kabelac
2013-05-06 17:17 ` Tony Asleson [this message]
2013-05-06 15:48 ` M. Mohan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5187E5A3.3090300@redhat.com \
--to=tasleson@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.