From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, klassert@mathematik.tu-chemnitz.de,
tedheadster@gmail.com
Subject: Re: [PATCH v2] 3c59x: fix PCI resource management
Date: Mon, 06 May 2013 21:29:40 +0400 [thread overview]
Message-ID: <5187E884.7060101@cogentembedded.com> (raw)
In-Reply-To: <20130506.122040.1138770239806939990.davem@davemloft.net>
Hello.
On 06-05-2013 20:20, David Miller wrote:
>> @@ -1215,12 +1217,13 @@ static int vortex_probe1(struct device *
>> vp->mii.reg_num_mask = 0x1f;
>>
>> /* Makes sure rings are at least 16 byte aligned. */
>> - vp->rx_ring = pci_alloc_consistent(pdev, sizeof(struct boom_rx_desc) * RX_RING_SIZE
>> - + sizeof(struct boom_tx_desc) * TX_RING_SIZE,
>> - &vp->rx_ring_dma);
>> + vp->rx_ring = pci_alloc_consistent(pdev,
>> + sizeof(struct boom_rx_desc) * RX_RING_SIZE +
>> + sizeof(struct boom_tx_desc) * TX_RING_SIZE,
>> + &vp->rx_ring_dma);
> This code was properly indented before your changes, but it isn't afterwards.
David, that's not my change, it's was Andrew Morton who changed that
(in order not to cross 80 columns).
WBR, Sergei
next prev parent reply other threads:[~2013-05-06 17:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 22:40 [PATCH v2] 3c59x: fix PCI resource management Sergei Shtylyov
2013-05-01 22:49 ` Sergei Shtylyov
2013-05-02 17:40 ` Sergei Shtylyov
2013-05-06 16:20 ` David Miller
2013-05-06 17:29 ` Sergei Shtylyov [this message]
2013-05-06 17:53 ` David Miller
2013-05-06 18:23 ` Sergei Shtylyov
2013-05-06 18:59 ` David Miller
2013-05-06 19:33 ` Sergei Shtylyov
2013-05-06 19:57 ` David Miller
2013-05-19 19:36 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5187E884.7060101@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=netdev@vger.kernel.org \
--cc=tedheadster@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.