From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sasha Levin <sasha.levin@oracle.com>
Subject: Re: [RFC PATCH 04/11] kvm tools: console: unconditionally output
 to any console
Date: Mon, 06 May 2013 17:04:47 -0400
Message-ID: <51881AEF.8030403@oracle.com>
References: <1367423416-24640-1-git-send-email-will.deacon@arm.com> <1367423416-24640-5-git-send-email-will.deacon@arm.com> <CAOJsxLGcZys-WYLg=rBON5iaaiHP6g_w-X3GXfpZz-R5BZtjJA@mail.gmail.com> <5183DF86.3040507@oracle.com> <20130503160940.GF8256@mudshark.cambridge.arm.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Pekka Enberg <penberg@kernel.org>, Asias He <asias@redhat.com>,
	KVM General <kvm@vger.kernel.org>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	"anup@brainfault.org" <anup@brainfault.org>,
	Rusty Russell <rusty@rustcorp.com.au>,
	"pranavkumar@linaro.org" <pranavkumar@linaro.org>,
	Michael Ellerman <michael@ellerman.id.au>
To: Will Deacon <will.deacon@arm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from userp1040.oracle.com ([156.151.31.81]:18254 "EHLO
	userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757706Ab3EFVFX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 6 May 2013 17:05:23 -0400
In-Reply-To: <20130503160940.GF8256@mudshark.cambridge.arm.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On 05/03/2013 12:09 PM, Will Deacon wrote:
> On Fri, May 03, 2013 at 05:02:14PM +0100, Sasha Levin wrote:
>> On 05/03/2013 05:19 AM, Pekka Enberg wrote:
>>> On Wed, May 1, 2013 at 6:50 PM, Will Deacon <will.deacon@arm.com> wrote:
>>>> From: Marc Zyngier <Marc.Zyngier@arm.com>
>>>>
>>>> Kvmtool suppresses any output to a console that has not been elected
>>>> as *the* console.
>>>>
>>>> While this makes sense on the input side (we want the input to be sent
>>>> to one console driver only), it seems to be the wrong thing to do on
>>>> the output side, as it effectively prevents the guest from switching
>>>> from one console to another (think earlyprintk using 8250 to virtio
>>>> console).
>>>>
>>>> After all, the guest *does* poke this device and outputs something
>>>> there.
>>>>
>>>> Just remove the kvm->cfg.active_console test from the output paths.
>>>>
>>>> Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
>>>> Signed-off-by: Will Deacon <will.deacon@arm.com>
>>>
>>> Seems reasonable. Asias, Sasha?
>>>
>>
>> I remember at trying it some time ago but dropped it for a reason I don't
>> remember at the moment.
>>
>> Can I have the weekend to play with it to try and figure out why?
> 
> There's no rush from my point of view (hence the RFC) so take as long as you
> need!

Looks good to me!


Thanks,
Sasha