From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eduardo Valentin Subject: Re: [RESEND][PATCH 1/3] arm: dts: introduce config HAS_BANDGAP Date: Mon, 6 May 2013 20:23:13 -0400 Message-ID: <51884971.9050508@ti.com> References: <1367874058-2378-1-git-send-email-eduardo.valentin@ti.com> <1367874058-2378-2-git-send-email-eduardo.valentin@ti.com> <20130506213413.GH5634@blackmetal.musicnaut.iki.fi> <20130506223653.GA12089@obsidianresearch.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0912381066301832574==" Return-path: In-Reply-To: <20130506223653.GA12089@obsidianresearch.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jason Gunthorpe Cc: Russell King , Aaro Koskinen , tony@atomide.com, linux-kernel@vger.kernel.org, Eduardo Valentin , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org --===============0912381066301832574== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2EAAKNRALDJVHSFIXMWNU" ------enig2EAAKNRALDJVHSFIXMWNU Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 06-05-2013 18:36, Jason Gunthorpe wrote: > On Tue, May 07, 2013 at 12:34:13AM +0300, Aaro Koskinen wrote: >> On Mon, May 06, 2013 at 05:00:56PM -0400, Eduardo Valentin wrote: >>> Introduce HAS_BANDGAP config entry. This config is a >>> boolean value so that arch code can flag is they >>> feature a bandgap device. >> >> Maybe it could be mentioned that omap-thermal already depend on this? >> At least for a random reviewer it was not immediately clear why this i= s >> added, especially since there were no users for it in subsequent patch= es. >=20 > I looked (very briefly), and it seemed like omap-thermal is self > contained and doesn't need arch support? >=20 It is. At least I tried to make it, at least to the extenstion I could ge= t. > I get the impression it is desired to minimize driver kconfig > dependencies to the minimum required to compile to increase build > testing coverage, so maybe it would be appropriate to drop this > entirely? >=20 Well, it is also desired to compile things to the correct target right? Thats the idea behind this config option. It follows the same design as CONFIG_ARCH_HAS_CPUFREQ, for instance. > Jason >=20 >=20 ------enig2EAAKNRALDJVHSFIXMWNU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlGISXEACgkQCXcVR3XQvP2GpgEAgnqZgHFcKy9T7f2uO57WcFrq w4XfekxJfXM1JCrRKWMBAOzCTYLNVb02G+ILWtM9fw4h2A9OXrpgvn7MNqZkG8ll =3ZQ/ -----END PGP SIGNATURE----- ------enig2EAAKNRALDJVHSFIXMWNU-- --===============0912381066301832574== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0912381066301832574==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: eduardo.valentin@ti.com (Eduardo Valentin) Date: Mon, 6 May 2013 20:23:13 -0400 Subject: [RESEND][PATCH 1/3] arm: dts: introduce config HAS_BANDGAP In-Reply-To: <20130506223653.GA12089@obsidianresearch.com> References: <1367874058-2378-1-git-send-email-eduardo.valentin@ti.com> <1367874058-2378-2-git-send-email-eduardo.valentin@ti.com> <20130506213413.GH5634@blackmetal.musicnaut.iki.fi> <20130506223653.GA12089@obsidianresearch.com> Message-ID: <51884971.9050508@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 06-05-2013 18:36, Jason Gunthorpe wrote: > On Tue, May 07, 2013 at 12:34:13AM +0300, Aaro Koskinen wrote: >> On Mon, May 06, 2013 at 05:00:56PM -0400, Eduardo Valentin wrote: >>> Introduce HAS_BANDGAP config entry. This config is a >>> boolean value so that arch code can flag is they >>> feature a bandgap device. >> >> Maybe it could be mentioned that omap-thermal already depend on this? >> At least for a random reviewer it was not immediately clear why this is >> added, especially since there were no users for it in subsequent patches. > > I looked (very briefly), and it seemed like omap-thermal is self > contained and doesn't need arch support? > It is. At least I tried to make it, at least to the extenstion I could get. > I get the impression it is desired to minimize driver kconfig > dependencies to the minimum required to compile to increase build > testing coverage, so maybe it would be appropriate to drop this > entirely? > Well, it is also desired to compile things to the correct target right? Thats the idea behind this config option. It follows the same design as CONFIG_ARCH_HAS_CPUFREQ, for instance. > Jason > > -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 295 bytes Desc: OpenPGP digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757890Ab3EGAYF (ORCPT ); Mon, 6 May 2013 20:24:05 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:56297 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752279Ab3EGAYD (ORCPT ); Mon, 6 May 2013 20:24:03 -0400 Message-ID: <51884971.9050508@ti.com> Date: Mon, 6 May 2013 20:23:13 -0400 From: Eduardo Valentin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130404 Thunderbird/17.0.5 MIME-Version: 1.0 To: Jason Gunthorpe CC: Aaro Koskinen , Eduardo Valentin , , , Russell King , , Subject: Re: [RESEND][PATCH 1/3] arm: dts: introduce config HAS_BANDGAP References: <1367874058-2378-1-git-send-email-eduardo.valentin@ti.com> <1367874058-2378-2-git-send-email-eduardo.valentin@ti.com> <20130506213413.GH5634@blackmetal.musicnaut.iki.fi> <20130506223653.GA12089@obsidianresearch.com> In-Reply-To: <20130506223653.GA12089@obsidianresearch.com> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2EAAKNRALDJVHSFIXMWNU" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ------enig2EAAKNRALDJVHSFIXMWNU Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 06-05-2013 18:36, Jason Gunthorpe wrote: > On Tue, May 07, 2013 at 12:34:13AM +0300, Aaro Koskinen wrote: >> On Mon, May 06, 2013 at 05:00:56PM -0400, Eduardo Valentin wrote: >>> Introduce HAS_BANDGAP config entry. This config is a >>> boolean value so that arch code can flag is they >>> feature a bandgap device. >> >> Maybe it could be mentioned that omap-thermal already depend on this? >> At least for a random reviewer it was not immediately clear why this i= s >> added, especially since there were no users for it in subsequent patch= es. >=20 > I looked (very briefly), and it seemed like omap-thermal is self > contained and doesn't need arch support? >=20 It is. At least I tried to make it, at least to the extenstion I could ge= t. > I get the impression it is desired to minimize driver kconfig > dependencies to the minimum required to compile to increase build > testing coverage, so maybe it would be appropriate to drop this > entirely? >=20 Well, it is also desired to compile things to the correct target right? Thats the idea behind this config option. It follows the same design as CONFIG_ARCH_HAS_CPUFREQ, for instance. > Jason >=20 >=20 ------enig2EAAKNRALDJVHSFIXMWNU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlGISXEACgkQCXcVR3XQvP2GpgEAgnqZgHFcKy9T7f2uO57WcFrq w4XfekxJfXM1JCrRKWMBAOzCTYLNVb02G+ILWtM9fw4h2A9OXrpgvn7MNqZkG8ll =3ZQ/ -----END PGP SIGNATURE----- ------enig2EAAKNRALDJVHSFIXMWNU--