All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <elder@inktank.com>
To: ceph-devel@vger.kernel.org
Subject: [PATCH 0/7] rbd: use common code for probe and refresh
Date: Mon, 06 May 2013 20:51:02 -0500	[thread overview]
Message-ID: <51885E06.8020201@inktank.com> (raw)

This is some work I had nearly done a long time ago.  It didn't even
have a bug associated with it.  I resurrected it over the weekend
and ported it to the new code.

It's basically cleanup though.  For format 1 rbd images, when
probing an image, header information for it is read in and
translated directly into the rbd_dev->header structure.

For an image refresh, instead, we use a stack structure to
hold the translated header, and then in a second step we
copy that into rbd_dev->header.

This series gets rid of the local variable, and always just
puts things directly into rbd_dev->header.  It also simplifies
probe and refresh for both format 1 and format 2, using a
common rbd_dev_vX_header_info() function for both purposes.

This set of patches, as well as the two single patches
and series of six I just posted, are available in the
"review/wip-rbd-cleanup-1" branch of the ceph-client git
repository.

					-Alex

[PATCH 1/7] rbd: set the mapping size and features later
[PATCH 2/7] rbd: zero format 1 header structure earlier
[PATCH 3/7] rbd: refactor rbd_header_from_disk()
[PATCH 4/7] rbd: update in-core header directly
[PATCH 5/7] rbd: simplify rbd_dev_v1_probe()
[PATCH 6/7] rbd: get rid of trivial v1 header wrappers
[PATCH 7/7] rbd: define rbd_dev_v1_header_info()


             reply	other threads:[~2013-05-07  1:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-07  1:51 Alex Elder [this message]
2013-05-07  1:52 ` [PATCH 1/7] rbd: set the mapping size and features later Alex Elder
2013-05-07  1:52 ` [PATCH 2/7] rbd: zero format 1 header structure earlier Alex Elder
2013-05-07  1:53 ` [PATCH 3/7] rbd: refactor rbd_header_from_disk() Alex Elder
2013-05-07  1:53 ` [PATCH 4/7] rbd: update in-core header directly Alex Elder
2013-05-07  1:53 ` [PATCH 5/7] rbd: simplify rbd_dev_v1_probe() Alex Elder
2013-05-07  1:53 ` [PATCH 6/7] rbd: get rid of trivial v1 header wrappers Alex Elder
2013-05-07  1:54 ` [PATCH 7/7] rbd: define rbd_dev_v1_header_info() Alex Elder
2013-05-08 19:29 ` [PATCH 0/7] rbd: use common code for probe and refresh Josh Durgin
2013-05-08 20:39   ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51885E06.8020201@inktank.com \
    --to=elder@inktank.com \
    --cc=ceph-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.