From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bo Shen <voice.shen@atmel.com>
Subject: Re: [PATCH] ASoC: sam9g20ek: Let device core handle
	pinctrl
Date: Tue, 7 May 2013 10:10:10 +0800
Message-ID: <51886282.8060106@atmel.com>
References: <1367868508-12329-1-git-send-email-broonie@opensource.wolfsonmicro.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from nasmtp02.atmel.com (nasmtp02.atmel.com [204.2.163.16])
 by alsa0.perex.cz (Postfix) with ESMTP id 95378260856
 for <alsa-devel@alsa-project.org>; Tue,  7 May 2013 04:10:57 +0200 (CEST)
In-Reply-To: <1367868508-12329-1-git-send-email-broonie@opensource.wolfsonmicro.com>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>, alsa-devel@alsa-project.org
List-Id: alsa-devel@alsa-project.org

Hi Mark,

On 5/7/2013 03:28, Mark Brown wrote:
> Since commit ab78029 (drivers/pinctrl: grab default handles from device
> core) we can rely on device core for handling pinctrl so remove
> devm_pinctrl_get_select_default() from the driver.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>   sound/soc/atmel/sam9g20_wm8731.c |    9 ---------
>   1 file changed, 9 deletions(-)
>
> diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
> index 2d6fbd0..802717e 100644
> --- a/sound/soc/atmel/sam9g20_wm8731.c
> +++ b/sound/soc/atmel/sam9g20_wm8731.c
> @@ -38,8 +38,6 @@
>   #include <linux/platform_device.h>
>   #include <linux/i2c.h>
>
> -#include <linux/pinctrl/consumer.h>
> -
>   #include <linux/atmel-ssc.h>
>
>   #include <sound/core.h>
> @@ -203,15 +201,8 @@ static int at91sam9g20ek_audio_probe(struct platform_device *pdev)
>   	struct device_node *codec_np, *cpu_np;
>   	struct clk *pllb;
>   	struct snd_soc_card *card = &snd_soc_at91sam9g20ek;
> -	struct pinctrl *pinctrl;
>   	int ret;
>
> -	pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
> -	if (IS_ERR(pinctrl)) {
> -		dev_err(&pdev->dev, "Failed to request pinctrl for mck\n");
> -		return PTR_ERR(pinctrl);
> -	}
> -

I have one question: with this patch, if lose default pinctrl 
configuration in dts/dtsi file, how should we know that?

Best Regards,
Bo Shen