Re: [PATCH 4/4] fast-import: only store commit objects

[Michael Haggerty <mhagger@alum.mit.edu>]

On 05/07/2013 06:47 AM, Felipe Contreras wrote:
> On Mon, May 6, 2013 at 10:27 PM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
> 
>> You conjectured earlier that nobody uses blob marks, and I provided a
>> counterexample.  Then you proposed a workaround that would require
>> changes to the cvs2git documentation, and I even explained how your
>> proposed workaround is not as flexible as the status quo.
> 
> cvs2git does *not* need blob marks, it does not need marks at all.
> 
> The use-case that you mentioned has nothing to do with cvs2git, in
> fact. I can be described as this:
> 
> % ./generate-blobs > blobs
> % git fast-import --export-marks=marks < blobs
> % ./generate-commits > commits
> % git fast-import --import-marks=marks < commits
> 
> In this example 'generate-commits' has no notion of marks at all, and
> 'git fast-import' doesn't need marks to process both blobs and
> commits.

The "generate-blobs" program generates a mark for each blob and
remembers the marks in a database.  The "generate-commits" program reads
the marks from the database and incorporates them in the definitions of
the commits that it writes to its output.  So yes, the program pair
*does* rely on marks for blobs being exported correctly.

I've tired of this discussion.  I am quite sure that your change will
not be accepted, so I see no need to participate further.  Please do not
interpret my silence as agreement with your quarrelsome arguments.

Michael

-- 
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/