From: Andre Przywara <andre.przywara@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: aliguori@us.ibm.com, kim.phillips@freescale.com, jdl@jdl.com,
hollisb@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] fdt: update embedded header file from upstream to fix compilation
Date: Tue, 07 May 2013 14:52:38 +0200 [thread overview]
Message-ID: <5188F916.5070500@linaro.org> (raw)
In-Reply-To: <CAFEAcA-GbfQAUn-ZePPjHyM4X4P50Lm=aXGOY9E5Xe9r4VtA9Q@mail.gmail.com>
On 05/07/2013 02:44 PM, Peter Maydell wrote:
> On 7 May 2013 13:36, Andre Przywara <andre.przywara@linaro.org> wrote:
>> Upstream dtc.git introduced a change in libfdt_env.h, which breaks
>> compilation with QEMU's version of it:
>>
>> CC arm-softmmu/device_tree.o
>> In file included from /usr/include/libfdt.h:55:0,
>> from /src/qemu.git/device_tree.c:28:
>> /usr/include/fdt.h:7:2: error: unknown type name 'fdt32_t'
>> ...
>
> I'm not entirely sure I understand why we need change.
> Have upstream really introduced a breaking change for
> everybody who uses libfdt, or are we using it wrongly?
Everybody who copies and changes a header from the original distribution
and uses this now instead of the installed version ;-)
libfdt (or better: dtc) seems to be quite out of date in the official
distribution packages. I just happened to have git HEAD installed manually.
Regards,
Andre.
next prev parent reply other threads:[~2013-05-07 12:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 12:36 [Qemu-devel] [PATCH] fdt: update embedded header file from upstream to fix compilation Andre Przywara
2013-05-07 12:44 ` Peter Maydell
2013-05-07 12:52 ` Andre Przywara [this message]
2013-05-07 13:24 ` Peter Maydell
2013-05-07 14:00 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5188F916.5070500@linaro.org \
--to=andre.przywara@linaro.org \
--cc=aliguori@us.ibm.com \
--cc=hollisb@us.ibm.com \
--cc=jdl@jdl.com \
--cc=kim.phillips@freescale.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.