From: Gerd Hoffmann <kraxel@redhat.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] uhci: Use an intermediate buffer for usb packet data
Date: Tue, 07 May 2013 15:36:45 +0200 [thread overview]
Message-ID: <5189036D.3030900@redhat.com> (raw)
In-Reply-To: <1367830137-9382-2-git-send-email-hdegoede@redhat.com>
On 05/06/13 10:48, Hans de Goede wrote:
> Due to various unfortunate reasons we cannot reliable detect a guest
> cancelling a packet as soon as it happens, instead we detect cancels
> with some delay.
>
> When packets are handled async, and we directly pass the guest memory for
> the packet to the usb-device as iovec, this means that the usb-device can
> write to guest-memory which the guest has already re-used for other purposes
> -> not good!
>
> This patch fixes this by adding an intermediate buffer and writing back not
> only the result, but also the data, of async completed packets when scanning
> the schedule.
Patch added to usb patch queue, pull req sent.
thanks,
Gerd
next prev parent reply other threads:[~2013-05-07 13:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-06 8:48 [Qemu-devel] [PATCH v2 0/1] uhci: Use an intermediate buffer for usb packet data Hans de Goede
2013-05-06 8:48 ` [Qemu-devel] [PATCH] " Hans de Goede
2013-05-07 13:36 ` Gerd Hoffmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-04-25 10:21 Hans de Goede
2013-04-26 12:32 ` Gerd Hoffmann
2013-04-26 14:01 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5189036D.3030900@redhat.com \
--to=kraxel@redhat.com \
--cc=hdegoede@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.