From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55432)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UZief-0006cZ-C2
	for qemu-devel@nongnu.org; Tue, 07 May 2013 10:14:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UZiea-0004hM-MU
	for qemu-devel@nongnu.org; Tue, 07 May 2013 10:14:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39238)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1UZiea-0004ge-Dm
	for qemu-devel@nongnu.org; Tue, 07 May 2013 10:14:04 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r47EE32O032175
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 7 May 2013 10:14:04 -0400
Message-ID: <51890C29.7020409@redhat.com>
Date: Tue, 07 May 2013 16:14:01 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1367933676-21854-1-git-send-email-kraxel@redhat.com>
	<1367933676-21854-6-git-send-email-kraxel@redhat.com>
	<20130507140601.GB22422@redhat.com>
In-Reply-To: <20130507140601.GB22422@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/6] xhci: add vmstate
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org

On 05/07/13 16:06, Michael S. Tsirkin wrote:
>> +#if 0
> should have a comment explaining why is this
> commented out.
> Or just drop this section.
> 
>> > +        /* event queue (used if ring is full) */
>> > +        VMSTATE_BOOL(er_full,         XHCIInterrupter),
>> > +        VMSTATE_UINT32(ev_buffer_put, XHCIInterrupter),
>> > +        VMSTATE_UINT32(ev_buffer_get, XHCIInterrupter),
>> > +        /* TODO */ XHCIEvent ev_buffer[EV_QUEUE];
>> > +#endif
>> > 

xhci buffers events in case the ring is full.  Doesn't happen under
normal circumstances, thats why I didn't bother finishing it (yet).

Doing that and stress-testing xhci migration are the todo list items
before I'll go merge this series.

cheers,
  Gerd