From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: netdev@vger.kernel.org, yoshihiro.shimoda.uh@renesas.com
Subject: Re: [PATCH v2] net: sh-eth: Add flag to determine the type of TSU register
Date: Tue, 07 May 2013 18:44:32 +0400 [thread overview]
Message-ID: <51891350.9060700@cogentembedded.com> (raw)
In-Reply-To: <1367903291-32323-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
Hello.
You shouldn't have posted this patch (and the subsequent series)
during the merge window, as David will probably tell you.
On 07-05-2013 9:08, Nobuhiro Iwamatsu wrote:
> Some sh-eth devices may have two ether devices inside.
You probably meant to say: "some SoCs may have two Ether devices
inside".
> And the function of TSU is accessed from each ether device.
> In this case, sh-eth need to remap address using devm_ioremap(),
> without using devm_ioremap_resource().
You could use devm_ioremap_resource() for the 1st Ether instance,
and devm_ioremap() for the 2nd, couldn't you?
> tsu_shared_reg of sh_eth_cpu_data is used for this control.
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
WBR, Sergei
next prev parent reply other threads:[~2013-05-07 14:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 5:08 [PATCH v2] net: sh-eth: Add flag to determine the type of TSU register Nobuhiro Iwamatsu
2013-05-07 14:44 ` Sergei Shtylyov [this message]
2013-06-04 17:19 ` Sergei Shtylyov
2013-06-05 5:12 ` Nobuhiro Iwamatsu
2013-06-03 22:07 ` Sergei Shtylyov
2013-06-05 14:21 ` Sergei Shtylyov
2018-01-02 17:27 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51891350.9060700@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=netdev@vger.kernel.org \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.