All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jiri Kosina <jkosina@suse.cz>, linux-input@vger.kernel.org
Subject: Re: [PATCHv2] hid: remove duplicate ID for D-WAV eGalax 0x7224
Date: Tue, 07 May 2013 16:48:05 +0200	[thread overview]
Message-ID: <51891425.5070300@redhat.com> (raw)
In-Reply-To: <1367937493-16844-1-git-send-email-andriy.shevchenko@linux.intel.com>

On 05/07/2013 04:38 PM, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---

I bet it will be easier to track for Jiri if you resend the full series:
- the egalax reordering
- the remove of the duplicate ID

As mentioned previously, also remove the entry in hid-multitouch (the
one containing MT_CLS_EGALAX, not the _SERIAL one).

Cheers,
Benjamin

>  drivers/hid/hid-ids.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 2378a0b..a5520ba 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -268,7 +268,6 @@
>  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7207	0x7207
>  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_720C	0x720c
>  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224	0x7224
> -#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224	0x7224
>  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_722A	0x722A
>  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_725E	0x725e
>  #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7262	0x7262
> 


  reply	other threads:[~2013-05-07 14:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1367936944-1624?= =?ISO-8859-1?Q?9-2-git-send-ema?= =?ISO-8859-1?Q?il-andriy.shevch?= =?ISO-8859-1?Q?enko@linux.intel?= =?ISO-8859-1?Q?.com=1B[B=1B[B=1B[B>
2013-05-07 14:38 ` [PATCHv2] hid: remove duplicate ID for D-WAV eGalax 0x7224 Andy Shevchenko
2013-05-07 14:48   ` Benjamin Tissoires [this message]
2013-05-08  7:23     ` Andy Shevchenko
2013-05-13  9:21       ` Benjamin Tissoires
2013-05-13 11:55         ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51891425.5070300@redhat.com \
    --to=benjamin.tissoires@redhat.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=jkosina@suse.cz \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.