From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Prochniak Subject: Xend FD leak upon migrate receive Date: Wed, 1 May 2013 09:50:19 -0700 (PDT) Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6291724432581986159==" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org --===============6291724432581986159== Content-Type: multipart/alternative; boundary="__1367427021073111709abhmt108.oracle.com" --__1367427021073111709abhmt108.oracle.com Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Xend leaks one fd each time a guest migrates to it's server. I'm wondering= if this is a known problem with a known fix, or if someone who knows that = code better than me could point me in the right direction. =20 =20 Thanks. --__1367427021073111709abhmt108.oracle.com Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: quoted-printable

Xend leaks one fd each time a guest migrates to it’= ;s server. I’m wondering if this is a known problem with a known f= ix, or if someone who knows that code better than me could point me in the right direction.

Thanks.

--__1367427021073111709abhmt108.oracle.com-- --===============6291724432581986159== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6291724432581986159==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: Xend FD leak upon migrate receive Date: Thu, 2 May 2013 12:42:11 +0100 Message-ID: <1367494931.21869.105.camel@zakaz.uk.xensource.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Steve Prochniak Cc: "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org T24gV2VkLCAyMDEzLTA1LTAxIGF0IDE3OjUwICswMTAwLCBTdGV2ZSBQcm9jaG5pYWsgd3JvdGU6 Cj4gWGVuZCBsZWFrcyBvbmUgZmQgZWFjaCB0aW1lIGEgZ3Vlc3QgbWlncmF0ZXMgdG8gaXTigJlz IHNlcnZlci4gIEnigJltCj4gd29uZGVyaW5nIGlmIHRoaXMgaXMgYSBrbm93biBwcm9ibGVtIHdp dGggYSBrbm93biBmaXgsIG9yIGlmIHNvbWVvbmUKPiB3aG8ga25vd3MgdGhhdCBjb2RlIGJldHRl ciB0aGFuIG1lIGNvdWxkIHBvaW50IG1lIGluIHRoZSByaWdodAo+IGRpcmVjdGlvbi4gIAoKSSdt IGFmcmFpZCB4ZW5kIGlzIGJhc2ljYWxseSB1bm1haW50YWluZWQgdGhlc2UgZGF5cyAod2hpY2gg aGFzIGNhdXNlZAp0byBiZWNvbWUgZGVwcmVjYXRlZCBpbiBjdXJyZW50IHJlbGVhc2VzKSBBRkFJ SyB0aGVyZSBhcmVuJ3QgYW55IHBlb3BsZQphcm91bmQgd2hvIGtub3cgdGhlIGNvZGUgaW4gYW55 IGdyZWF0IGRldGFpbC4KCkkgZG9uJ3QgcmVjYWxsIGhhdmluZyBoZWFyZCBvZiBhbnl0aGluZyBh bG9uZyB0aGUgbGluZXMgb2Ygd2hhdCB5b3UKcmVwb3J0IHNvIEkgZG9uJ3QgdGhpbmsgaXQgaXMg YSBrbm93biBwcm9ibGVtLgoKSWFuLgoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54 ZW4ub3JnCmh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sander Eikelenboom Subject: Re: Xend FD leak upon migrate receive Date: Thu, 2 May 2013 15:36:55 +0200 Message-ID: <1168699139.20130502153655@eikelenboom.it> References: <1367494931.21869.105.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1367494931.21869.105.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Steve Prochniak , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org DQpUaHVyc2RheSwgTWF5IDIsIDIwMTMsIDE6NDI6MTEgUE0sIHlvdSB3cm90ZToKCj4gT24gV2Vk LCAyMDEzLTA1LTAxIGF0IDE3OjUwICswMTAwLCBTdGV2ZSBQcm9jaG5pYWsgd3JvdGU6Cj4+IFhl bmQgbGVha3Mgb25lIGZkIGVhY2ggdGltZSBhIGd1ZXN0IG1pZ3JhdGVzIHRvIGl04oCZcyBzZXJ2 ZXIuICBJ4oCZbQo+PiB3b25kZXJpbmcgaWYgdGhpcyBpcyBhIGtub3duIHByb2JsZW0gd2l0aCBh IGtub3duIGZpeCwgb3IgaWYgc29tZW9uZQo+PiB3aG8ga25vd3MgdGhhdCBjb2RlIGJldHRlciB0 aGFuIG1lIGNvdWxkIHBvaW50IG1lIGluIHRoZSByaWdodAo+PiBkaXJlY3Rpb24uICAKCj4gSSdt IGFmcmFpZCB4ZW5kIGlzIGJhc2ljYWxseSB1bm1haW50YWluZWQgdGhlc2UgZGF5cyAod2hpY2gg aGFzIGNhdXNlZAo+IHRvIGJlY29tZSBkZXByZWNhdGVkIGluIGN1cnJlbnQgcmVsZWFzZXMpIEFG QUlLIHRoZXJlIGFyZW4ndCBhbnkgcGVvcGxlCj4gYXJvdW5kIHdobyBrbm93IHRoZSBjb2RlIGlu IGFueSBncmVhdCBkZXRhaWwuCgo+IEkgZG9uJ3QgcmVjYWxsIGhhdmluZyBoZWFyZCBvZiBhbnl0 aGluZyBhbG9uZyB0aGUgbGluZXMgb2Ygd2hhdCB5b3UKPiByZXBvcnQgc28gSSBkb24ndCB0aGlu ayBpdCBpcyBhIGtub3duIHByb2JsZW0uCgpJc24ndCB0aGlzIHRoZSBzYW1lIGFzIHRoZToKIHRl c3QtYW1kNjQtaTM4Ni14ZW5kLXdpbnhwc3AzIDE2IGxlYWstY2hlY2svY2hlY2sgICAgICAgICAg ICAgZmFpbCAgbmV2ZXIgcGFzcwogdGVzdC1hbWQ2NC1pMzg2LXhlbmQtcWVtdXQtd2lueHBzcDMg MTYgbGVhay1jaGVjay9jaGVjayAgICAgICAgZmFpbCBuZXZlciBwYXNzCgogUmVwb3J0ZWQgaW4g YWJvdXQgZXZlcnkgYXV0b21hdGVkIHRlc3QgKGEgYml0IGhpZGRlbiBieSBldmVyIHByZXNlbnQg Imd1ZXN0LXN0b3AiIHByb2JsZW0KIChkdWUgdG8gbGFjayBvZiB0aGUgLUYgb24gc2h1dGRvd24g Zm9yIEhWTSBndWVzdHMgd2l0aG91dCBQViBkcml2ZXJzKSkKCiAtLQogU2FuZGVyCgo+IElhbi4K CgoKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVu LWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwOi8vbGlzdHMu eGVuLm9yZy94ZW4tZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: Xend FD leak upon migrate receive Date: Thu, 2 May 2013 14:42:04 +0100 Message-ID: <1367502124.21869.117.camel@zakaz.uk.xensource.com> References: <1367494931.21869.105.camel@zakaz.uk.xensource.com> <1168699139.20130502153655@eikelenboom.it> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1168699139.20130502153655@eikelenboom.it> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Sander Eikelenboom Cc: Steve Prochniak , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org T24gVGh1LCAyMDEzLTA1LTAyIGF0IDE0OjM2ICswMTAwLCBTYW5kZXIgRWlrZWxlbmJvb20gd3Jv dGU6Cj4gVGh1cnNkYXksIE1heSAyLCAyMDEzLCAxOjQyOjExIFBNLCB5b3Ugd3JvdGU6Cj4gCj4g PiBPbiBXZWQsIDIwMTMtMDUtMDEgYXQgMTc6NTAgKzAxMDAsIFN0ZXZlIFByb2NobmlhayB3cm90 ZToKPiA+PiBYZW5kIGxlYWtzIG9uZSBmZCBlYWNoIHRpbWUgYSBndWVzdCBtaWdyYXRlcyB0byBp dOKAmXMgc2VydmVyLiAgSeKAmW0KPiA+PiB3b25kZXJpbmcgaWYgdGhpcyBpcyBhIGtub3duIHBy b2JsZW0gd2l0aCBhIGtub3duIGZpeCwgb3IgaWYgc29tZW9uZQo+ID4+IHdobyBrbm93cyB0aGF0 IGNvZGUgYmV0dGVyIHRoYW4gbWUgY291bGQgcG9pbnQgbWUgaW4gdGhlIHJpZ2h0Cj4gPj4gZGly ZWN0aW9uLiAgCj4gCj4gPiBJJ20gYWZyYWlkIHhlbmQgaXMgYmFzaWNhbGx5IHVubWFpbnRhaW5l ZCB0aGVzZSBkYXlzICh3aGljaCBoYXMgY2F1c2VkCj4gPiB0byBiZWNvbWUgZGVwcmVjYXRlZCBp biBjdXJyZW50IHJlbGVhc2VzKSBBRkFJSyB0aGVyZSBhcmVuJ3QgYW55IHBlb3BsZQo+ID4gYXJv dW5kIHdobyBrbm93IHRoZSBjb2RlIGluIGFueSBncmVhdCBkZXRhaWwuCj4gCj4gPiBJIGRvbid0 IHJlY2FsbCBoYXZpbmcgaGVhcmQgb2YgYW55dGhpbmcgYWxvbmcgdGhlIGxpbmVzIG9mIHdoYXQg eW91Cj4gPiByZXBvcnQgc28gSSBkb24ndCB0aGluayBpdCBpcyBhIGtub3duIHByb2JsZW0uCj4g Cj4gSXNuJ3QgdGhpcyB0aGUgc2FtZSBhcyB0aGU6Cj4gIHRlc3QtYW1kNjQtaTM4Ni14ZW5kLXdp bnhwc3AzIDE2IGxlYWstY2hlY2svY2hlY2sgICAgICAgICAgICAgZmFpbCAgbmV2ZXIgcGFzcwo+ ICB0ZXN0LWFtZDY0LWkzODYteGVuZC1xZW11dC13aW54cHNwMyAxNiBsZWFrLWNoZWNrL2NoZWNr ICAgICAgICBmYWlsIG5ldmVyIHBhc3MKCldoeSBkbyB5b3UgdGhpbmsgdGhhdD8KCkFGQUlLIHRo aXMgaXMgY2hlY2tpbmcgZm9yIGxlYWtlZCBmaWxlcyAobm90IGZpbGUgZGVzY3JpcHRvcnMpIGFu ZAp4ZW5zdG9yZSBlbnRyaWVzIGV0Yy4gQWxzbyBpdCBzZWVtcyB0byBwYXNzIGZvciBvdGhlciB0 ZXN0IHNlcXVlbmNlcwp3aGljaCBhbHNvIGludm9sdmUgeGVuZCBhbmQgbWlncmF0aW9uLgoKSWFu LgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClhlbi1k ZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKaHR0cDovL2xpc3RzLnhl bi5vcmcveGVuLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Prochniak Subject: Re: Xend FD leak upon migrate receive Date: Thu, 2 May 2013 13:26:52 -0700 (PDT) Message-ID: References: <1367494931.21869.105.camel@zakaz.uk.xensource.com> <1168699139.20130502153655@eikelenboom.it> <1367502124.21869.117.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1367502124.21869.117.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Sander Eikelenboom Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Fyi - the leak occurs on the receiver side and only exists when using SSL migration. I don't know if that rings any bells or not. -----Original Message----- From: Ian Campbell [mailto:Ian.Campbell@citrix.com] Sent: Thursday, May 02, 2013 9:42 AM To: Sander Eikelenboom Cc: Steve Prochniak; xen-devel@lists.xen.org Subject: Re: [Xen-devel] Xend FD leak upon migrate receive On Thu, 2013-05-02 at 14:36 +0100, Sander Eikelenboom wrote: > Thursday, May 2, 2013, 1:42:11 PM, you wrote: > > > On Wed, 2013-05-01 at 17:50 +0100, Steve Prochniak wrote: > >> Xend leaks one fd each time a guest migrates to it's server. I'm > >> wondering if this is a known problem with a known fix, or if someone > >> who knows that code better than me could point me in the right > >> direction. > > > I'm afraid xend is basically unmaintained these days (which has caused > > to become deprecated in current releases) AFAIK there aren't any people > > around who know the code in any great detail. > > > I don't recall having heard of anything along the lines of what you > > report so I don't think it is a known problem. > > Isn't this the same as the: > test-amd64-i386-xend-winxpsp3 16 leak-check/check fail never pass > test-amd64-i386-xend-qemut-winxpsp3 16 leak-check/check fail never pass Why do you think that? AFAIK this is checking for leaked files (not file descriptors) and xenstore entries etc. Also it seems to pass for other test sequences which also involve xend and migration. Ian. _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jim Fehlig Subject: Re: Xend FD leak upon migrate receive Date: Tue, 07 May 2013 09:31:19 -0600 Message-ID: <51891E47.1020606@suse.com> References: <1367494931.21869.105.camel@zakaz.uk.xensource.com> <1168699139.20130502153655@eikelenboom.it> <1367502124.21869.117.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Steve Prochniak Cc: Sander Eikelenboom , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Steve Prochniak wrote: > Fyi - the leak occurs on the receiver side and only exists when using SSL migration. I don't know if that rings any bells or not. > Maybe op_quit() in tools/python/xen/xend/server/relocate.py needs to handle cleaning up the pipe created in op_sslreceive()? Regards, Jim > -----Original Message----- > From: Ian Campbell [mailto:Ian.Campbell@citrix.com] > Sent: Thursday, May 02, 2013 9:42 AM > To: Sander Eikelenboom > Cc: Steve Prochniak; xen-devel@lists.xen.org > Subject: Re: [Xen-devel] Xend FD leak upon migrate receive > > On Thu, 2013-05-02 at 14:36 +0100, Sander Eikelenboom wrote: > >> Thursday, May 2, 2013, 1:42:11 PM, you wrote: >> >> >>> On Wed, 2013-05-01 at 17:50 +0100, Steve Prochniak wrote: >>> >>>> Xend leaks one fd each time a guest migrates to it's server. I'm >>>> wondering if this is a known problem with a known fix, or if someone >>>> who knows that code better than me could point me in the right >>>> direction. >>>> >>> I'm afraid xend is basically unmaintained these days (which has caused >>> to become deprecated in current releases) AFAIK there aren't any people >>> around who know the code in any great detail. >>> >>> I don't recall having heard of anything along the lines of what you >>> report so I don't think it is a known problem. >>> >> Isn't this the same as the: >> test-amd64-i386-xend-winxpsp3 16 leak-check/check fail never pass >> test-amd64-i386-xend-qemut-winxpsp3 16 leak-check/check fail never pass >> > > Why do you think that? > > AFAIK this is checking for leaked files (not file descriptors) and > xenstore entries etc. Also it seems to pass for other test sequences > which also involve xend and migration. > > Ian. > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Steve Prochniak Subject: Re: Xend FD leak upon migrate receive Date: Wed, 8 May 2013 11:19:59 -0700 (PDT) Message-ID: References: <1367494931.21869.105.camel@zakaz.uk.xensource.com> <1168699139.20130502153655@eikelenboom.it> <1367502124.21869.117.camel@zakaz.uk.xensource.com> <51891E47.1020606@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <51891E47.1020606@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jim Fehlig Cc: Sander Eikelenboom , Ian Campbell , xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org Thanks Jim - That's really close to what I've been testing. I close the p2cread fd in op_sslreceive (but outside of the except: scope), and I believe that the p2cwrite fd gets closed as part of the recv2fd thread that runs in connection.py. So far so good. Steve -----Original Message----- From: Jim Fehlig [mailto:jfehlig@suse.com] Sent: Tuesday, May 07, 2013 11:31 AM To: Steve Prochniak Cc: Sander Eikelenboom; Ian Campbell; xen-devel@lists.xen.org Subject: Re: [Xen-devel] Xend FD leak upon migrate receive Steve Prochniak wrote: > Fyi - the leak occurs on the receiver side and only exists when using SSL migration. I don't know if that rings any bells or not. > Maybe op_quit() in tools/python/xen/xend/server/relocate.py needs to handle cleaning up the pipe created in op_sslreceive()? Regards, Jim > -----Original Message----- > From: Ian Campbell [mailto:Ian.Campbell@citrix.com] > Sent: Thursday, May 02, 2013 9:42 AM > To: Sander Eikelenboom > Cc: Steve Prochniak; xen-devel@lists.xen.org > Subject: Re: [Xen-devel] Xend FD leak upon migrate receive > > On Thu, 2013-05-02 at 14:36 +0100, Sander Eikelenboom wrote: > >> Thursday, May 2, 2013, 1:42:11 PM, you wrote: >> >> >>> On Wed, 2013-05-01 at 17:50 +0100, Steve Prochniak wrote: >>> >>>> Xend leaks one fd each time a guest migrates to it's server. I'm >>>> wondering if this is a known problem with a known fix, or if someone >>>> who knows that code better than me could point me in the right >>>> direction. >>>> >>> I'm afraid xend is basically unmaintained these days (which has caused >>> to become deprecated in current releases) AFAIK there aren't any people >>> around who know the code in any great detail. >>> >>> I don't recall having heard of anything along the lines of what you >>> report so I don't think it is a known problem. >>> >> Isn't this the same as the: >> test-amd64-i386-xend-winxpsp3 16 leak-check/check fail never pass >> test-amd64-i386-xend-qemut-winxpsp3 16 leak-check/check fail never pass >> > > Why do you think that? > > AFAIK this is checking for leaked files (not file descriptors) and > xenstore entries etc. Also it seems to pass for other test sequences > which also involve xend and migration. > > Ian. > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel > > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel