From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33286) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZlfP-0002qU-58 for qemu-devel@nongnu.org; Tue, 07 May 2013 13:27:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZlfN-0001Y4-G8 for qemu-devel@nongnu.org; Tue, 07 May 2013 13:27:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30416) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZlfN-0001Xw-7G for qemu-devel@nongnu.org; Tue, 07 May 2013 13:27:05 -0400 Message-ID: <51893967.80503@redhat.com> Date: Tue, 07 May 2013 11:27:03 -0600 From: Eric Blake MIME-Version: 1.0 References: <518923DA.6030105@redhat.com> <1367945808-19979-1-git-send-email-lersek@redhat.com> In-Reply-To: <1367945808-19979-1-git-send-email-lersek@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2CKELHBKXGGTPJGFNLNAE" Subject: Re: [Qemu-devel] [PATCH 1/2] qga: distinguish binary modes in "guest_file_open_modes" map List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2CKELHBKXGGTPJGFNLNAE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 05/07/2013 10:56 AM, Laszlo Ersek wrote: > In Windows guests this may make a difference. >=20 > Suggested-by: Eric Blake > Signed-off-by: Laszlo Ersek > --- > qga/commands-posix.c | 22 ++++++++++++++++------ > 1 files changed, 16 insertions(+), 6 deletions(-) >=20 > diff --git a/qga/commands-posix.c b/qga/commands-posix.c > index 04c6951..2eec712 100644 > --- a/qga/commands-posix.c > +++ b/qga/commands-posix.c Oh, and only NOW do I notice that this is in a file named commands-posix.c that doesn't get compiled into the Windows build of qga (there, we only build commands-win32.c, and THAT file always fails this command, because no one has ported guest-file-open there yet). But I guess there is still the argument that some weirdnix system exists that isn't quite POSIX compliant and does have a distinct binary mode (maybe someone plans on compiling qga for Cygwin instead of native windows, since at least that would be able to open files when the commands-win32.c variant doesn't?), so I still think the patch is worth keeping. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2CKELHBKXGGTPJGFNLNAE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRiTlnAAoJEKeha0olJ0NqxBgIAIc6ke2CRJhLq2IILlc5UzSJ mPnwkzsrHGg50zP1hsNOUyVBLk1lAlQA6YLgWlzeVQWqM08FFUShZiuQfe7hy1L9 pSWqikQflXdp0jZNRbJRJX2I3Bp502232adtiC7zkFgiZRpCDF8QEiTM5aLk1+7J dO9IiLLYbx+kdriafgrfiySJLOxsqGJocrrKaIuM1W7uTVwGrw7Tn/LlojqOTWnG 9kraGhvLIZj+rvlJdbyCrOfUXk4Fk0GLwmBvmMTPBib6SI3pE9oP+F0AmVK3ppAm 99sBZM1hQ1NwK9x1zncqkOXI2BmPVRJmzGNPnxJrqDI+TgxlVeU1K9CIQ4b+rc4= =UE9Y -----END PGP SIGNATURE----- ------enig2CKELHBKXGGTPJGFNLNAE--