From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZoah-0002pY-Mj for qemu-devel@nongnu.org; Tue, 07 May 2013 16:34:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZoaf-0001he-B0 for qemu-devel@nongnu.org; Tue, 07 May 2013 16:34:26 -0400 Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:58709) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZoVX-00006Q-Fs for qemu-devel@nongnu.org; Tue, 07 May 2013 16:29:07 -0400 Received: by mail-wg0-f43.google.com with SMTP id c11so1104728wgh.10 for ; Tue, 07 May 2013 13:29:06 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <5189640A.6010500@redhat.com> Date: Tue, 07 May 2013 22:28:58 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1367946947-17109-1-git-send-email-jordan.l.justen@intel.com> In-Reply-To: <1367946947-17109-1-git-send-email-jordan.l.justen@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 0/6] KVM flash memory support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jordan Justen Cc: Anthony Liguori , qemu-devel@nongnu.org Il 07/05/2013 19:15, Jordan Justen ha scritto: > git://github.com/jljusten/qemu.git kvm-flash-v4 > > Utilize KVM_CAP_READONLY_MEM to support PC system flash emulation > with KVM. > > v4: > * With a machine type of isapc, don't mark the BIOS as read-only. > isapc + seabios will not boot if the BIOS is read-only. This > matches the current behavior of isapc with KVM, which is the > only mode under which isapc currently works. Thanks for looking at it! Patch 1 should definitely be 1.5 material. At this point it is late for 1.5 and I found a small problem in patch 3, so let's defer it. However, I'm thinking of reverting commit 9953f8822 in 1.5. Yes, it's a bugfix but the change is only visible in TCG and having three modes in three versions is uselessly complicated. Paolo > v3: > * Squash patch 2 & 3 based on Xiao's feedback that what I > was calling a 'workaround' in patch 3 was actually what > is required by the KVM READONLY memory support. > > v2: > * Remove rom_only from PC_COMPAT_1_4 > * Only enable flash when a pflash drive is created. > > Jordan Justen (6): > isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS) > kvm: add kvm_readonly_mem_enabled > kvm: support using KVM_MEM_READONLY flag for readonly regions > pflash_cfi01: memory region should be set to enable readonly mode > pc_sysfw: allow flash (-pflash) memory to be used with KVM > pc_sysfw: change rom_only default to 0 > > hw/block/pc_sysfw.c | 64 ++++++++++++++++++++++++++++++----------------- > hw/block/pflash_cfi01.c | 2 ++ > hw/i386/pc_piix.c | 5 ++++ > include/hw/i386/pc.h | 4 --- > include/sysemu/kvm.h | 10 ++++++++ > kvm-all.c | 42 ++++++++++++++++++++++++------- > kvm-stub.c | 1 + > 7 files changed, 92 insertions(+), 36 deletions(-) >