From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36600)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UZoc2-00049o-C1
	for qemu-devel@nongnu.org; Tue, 07 May 2013 16:35:51 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UZoc0-0002E7-La
	for qemu-devel@nongnu.org; Tue, 07 May 2013 16:35:50 -0400
Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:56679)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1UZoc0-0002Du-6G
	for qemu-devel@nongnu.org; Tue, 07 May 2013 16:35:48 -0400
Received: by mail-wg0-f42.google.com with SMTP id j13so4367544wgh.5
	for <qemu-devel@nongnu.org>; Tue, 07 May 2013 13:35:47 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <5189659A.2070307@redhat.com>
Date: Tue, 07 May 2013 22:35:38 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1367946947-17109-1-git-send-email-jordan.l.justen@intel.com>
	<1367946947-17109-5-git-send-email-jordan.l.justen@intel.com>
In-Reply-To: <1367946947-17109-5-git-send-email-jordan.l.justen@intel.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 4/6] pflash_cfi01: memory region should
 be set to enable readonly mode
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jordan Justen <jordan.l.justen@intel.com>
Cc: qemu-devel@nongnu.org

Il 07/05/2013 19:15, Jordan Justen ha scritto:
> This causes any writes to the memory region to trap to the
> device handler.
> 
> This is also important for KVM, because this allows the memory
> region to be set using KVM_MEM_READONLY, which allows the memory
> region to be read & executed. (Without this, KVM will not support
> executing from the memory region.)
> 
> Signed-off-by: Jordan Justen <jordan.l.justen@intel.com>
> ---
>  hw/block/pflash_cfi01.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/block/pflash_cfi01.c b/hw/block/pflash_cfi01.c
> index 3ff20e0..b65225e 100644
> --- a/hw/block/pflash_cfi01.c
> +++ b/hw/block/pflash_cfi01.c
> @@ -596,6 +596,8 @@ static int pflash_cfi01_init(SysBusDevice *dev)
>          }
>      }
>  
> +    memory_region_set_readonly(&pfl->mem, true);
> +
>      if (pfl->bs) {
>          pfl->ro = bdrv_is_read_only(pfl->bs);
>      } else {
> 

NACK, romd mode already implies this.  See my review of patch 3.

Paolo