From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@suse.com>
Subject: Re: [PATCH] libxl: do not call exit()
	in	libxl_device_vtpm_list
Date: Tue, 07 May 2013 23:28:35 -0600
Message-ID: <5189E283.1010302@suse.com>
References: <20130508042441.5815127B@duch.mimuw.edu.pl>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <20130508042441.5815127B@duch.mimuw.edu.pl>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Marek Marczykowski <marmarek@invisiblethingslab.com>
Cc: Ian Campbell <ian.campbell@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

Marek Marczykowski wrote:
> Signal error with NULL return value, do not terminate the whole process.
>
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>
> ---
>  tools/libxl/libxl.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
> index 03fd35a..5b9a3df 100644
> --- a/tools/libxl/libxl.c
> +++ b/tools/libxl/libxl.c
> @@ -1860,11 +1860,12 @@ libxl_device_vtpm *libxl_device_vtpm_list(libxl_ctx *ctx, uint32_t domid, int *n
>            vtpm->backend_domid = atoi(tmp);
>  
>            tmp = libxl__xs_read(gc, XBT_NULL, GCSPRINTF("%s/uuid", be_path));
> -          if(tmp) {
> -             if(libxl_uuid_from_string(&(vtpm->uuid), tmp)) {
> -                LOG(ERROR, "%s/uuid is a malformed uuid?? (%s) Probably a bug!!\n", be_path, tmp);
> -                exit(1);
> -             }
>   

Ouch.  libxl shouldn't be calling exit :).

> +          if (tmp) {
> +              if(libxl_uuid_from_string(&(vtpm->uuid), tmp)) {
> +                  LOG(ERROR, "%s/uuid is a malformed uuid?? (%s) Probably a bug!!\n", be_path, tmp);
> +                  free(vtpms);
> +                  return NULL;
> +              }
>            }
>         }
>      }
>   

    Reviewed-by: Jim Fehlig <jfehlig@suse.com>

Regards,
Jim