From: Bart Van Assche <bvanassche@acm.org>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: device-mapper development <dm-devel@redhat.com>,
Christophe Varoqui <christophe.varoqui@gmail.com>
Subject: Re: [PATCH 2/2] simplify multipath signal handlers
Date: Wed, 08 May 2013 07:58:50 +0200 [thread overview]
Message-ID: <5189E99A.4000309@acm.org> (raw)
In-Reply-To: <20130507221557.GU6253@ether.msp.redhat.com>
On 05/08/13 00:15, Benjamin Marzinski wrote:
> + sigprocmask(SIG_SETMASK, NULL, &mask);
Not sure this is relevant on Linux, but the POSIX specs require to use
pthread_sigmask() in multithreaded programs instead of sigprocmask()
(see also
http://pubs.opengroup.org/onlinepubs/9699919799/functions/pthread_sigmask.html).
Otherwise this patch looks fine to me.
Bart.
prev parent reply other threads:[~2013-05-08 5:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 22:12 [PATCH 1/2] Add missing includes for remember_wwid Benjamin Marzinski
2013-05-07 22:15 ` [PATCH 2/2] simplify multipath signal handlers Benjamin Marzinski
2013-05-08 5:58 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5189E99A.4000309@acm.org \
--to=bvanassche@acm.org \
--cc=bmarzins@redhat.com \
--cc=christophe.varoqui@gmail.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.