From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48324) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZyeN-0000UR-Cp for qemu-devel@nongnu.org; Wed, 08 May 2013 03:18:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZyeI-0000V8-Sf for qemu-devel@nongnu.org; Wed, 08 May 2013 03:18:55 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:60346) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZyeI-0000BY-Kp for qemu-devel@nongnu.org; Wed, 08 May 2013 03:18:50 -0400 Message-ID: <5189FC50.4020503@msgid.tls.msk.ru> Date: Wed, 08 May 2013 11:18:40 +0400 From: Michael Tokarev MIME-Version: 1.0 References: <20120110173816.GB6244@volta.aurel32.net> <515FBBC9.1020800@msgid.tls.msk.ru> In-Reply-To: <515FBBC9.1020800@msgid.tls.msk.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] sparc-linux-user: Fix missing symbols in .rel/.rela.plt sections List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno Cc: Blue Swirl , qemu-devel@nongnu.org Ping #2? 06.04.2013 10:08, Michael Tokarev wrote: > This patch was submitted more than a year ago (at Jan-2012). > Is it still needed? If yes, why it hasn't been applied? > > It still applies cleanly to the current git, with the exception > of s|^|ldscripts/| - sparc.ld moved from the top directory to > ldscripts/. > > (Ref: http://patchwork.ozlabs.org/patch/135267 ) > > Thanks, > > /mjt > > > 10.01.2012 11:38, Aurelien Jarno wrote: >> sparc-linux-user: Fix missing symbols in .rel/.rela.plt sections >> >> Fix .rel.plt sections in the output to not only include .rel.plt >> sections from the input but also the .rel.iplt sections and to define >> the hidden symbols __rel_iplt_start and __rel_iplt_end around >> .rel.iplt as otherwise we get undefined references to these when >> linking statically to a multiarch enabled libc (using STT_GNU_IFUNC). >> >> Cc: Blue Swirl >> Signed-off-by: Aurelien Jarno >> >> --- >> sparc.ld | 16 ++++++++++++++-- >> 1 files changed, 14 insertions(+), 2 deletions(-) >> >> diff --git a/sparc.ld b/sparc.ld >> index 56efe34..cec17c9 100644 >> --- a/sparc.ld >> +++ b/sparc.ld >> @@ -37,8 +37,20 @@ SECTIONS >> .rela.fini : { *(.rela.fini) } >> .rel.bss : { *(.rel.bss) } >> .rela.bss : { *(.rela.bss) } >> - .rel.plt : { *(.rel.plt) } >> - .rela.plt : { *(.rela.plt) } >> + .rel.plt : >> + { >> + *(.rel.plt) >> + PROVIDE (__rel_iplt_start = .); >> + *(.rel.iplt) >> + PROVIDE (__rel_iplt_end = .); >> + } >> + .rela.plt : >> + { >> + *(.rela.plt) >> + PROVIDE (__rela_iplt_start = .); >> + *(.rela.iplt) >> + PROVIDE (__rela_iplt_end = .); >> + } >> .init : { *(.init) } =0x47ff041f >> .text : >> { >> > >