All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Marek Marczykowski <marmarek@invisiblethingslab.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	"xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
Subject: Re: [PATCH v2 1/3] libxl: add libxl__xs_get_permissions helper
Date: Wed, 8 May 2013 11:32:08 +0200	[thread overview]
Message-ID: <518A1B98.9000600@citrix.com> (raw)
In-Reply-To: <8834e489cf1b00a22bb021a1d422563b66c9d898.1367987733.git.marmarek@invisiblethingslab.com>

On 08/05/13 05:39, Marek Marczykowski wrote:
> 
> Signed-off-by: Marek Marczykowski <marmarek@invisiblethingslab.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

> ---
>  tools/libxl/libxl_internal.h |  2 ++
>  tools/libxl/libxl_xshelp.c   | 11 +++++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 573e3d1..2e9d9b5 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -533,6 +533,8 @@ _hidden char *libxl__xs_get_dompath(libxl__gc *gc, uint32_t domid);
>  
>  _hidden char *libxl__xs_read(libxl__gc *gc, xs_transaction_t t,
>                               const char *path);
> +_hidden struct xs_permissions * libxl__xs_get_permissions(libxl__gc *gc,
> +                xs_transaction_t t, const char *path, unsigned int *num);
>  _hidden char **libxl__xs_directory(libxl__gc *gc, xs_transaction_t t,
>                                     const char *path, unsigned int *nb);
>     /* On error: returns NULL, sets errno (no logging) */
> diff --git a/tools/libxl/libxl_xshelp.c b/tools/libxl/libxl_xshelp.c
> index 52af484..48960de 100644
> --- a/tools/libxl/libxl_xshelp.c
> +++ b/tools/libxl/libxl_xshelp.c
> @@ -115,6 +115,17 @@ char * libxl__xs_read(libxl__gc *gc, xs_transaction_t t, const char *path)
>      return ptr;
>  }
>  
> +struct xs_permissions * libxl__xs_get_permissions(libxl__gc *gc,
> +        xs_transaction_t t, const char *path, unsigned int *num)
> +{
> +    libxl_ctx *ctx = libxl__gc_owner(gc);
> +    struct xs_permissions *ptr;
> +
> +    ptr = xs_get_permissions(ctx->xsh, t, path, num);
> +    libxl__ptr_add(gc, ptr);
> +    return ptr;
> +}
> +
>  char *libxl__xs_get_dompath(libxl__gc *gc, uint32_t domid)
>  {
>      libxl_ctx *ctx = libxl__gc_owner(gc);
> 

  reply	other threads:[~2013-05-08  9:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08  4:35 [PATCH v2 0/3] Get devices list from frontend xenstore entries Marek Marczykowski
2013-05-08  3:39 ` [PATCH v2 2/3] libxl: do not assume Dom0 backend while listing disks and nics Marek Marczykowski
2013-05-08 10:22   ` Roger Pau Monné
2013-05-08  3:39 ` [PATCH v2 1/3] libxl: add libxl__xs_get_permissions helper Marek Marczykowski
2013-05-08  9:32   ` Roger Pau Monné [this message]
2013-05-08  3:48 ` [PATCH v2 3/3] libxl: reduce code duplication in libxl_device_vtpm_list Marek Marczykowski
2013-05-08 11:49 ` [PATCH v2 0/3] Get devices list from frontend xenstore entries Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518A1B98.9000600@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=marmarek@invisiblethingslab.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.