From: Saul Wold <sgw@linux.intel.com>
To: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
Bogdan Marinescu <bogdan.a.marinescu@intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/4] gdb: add 7.6 version
Date: Wed, 08 May 2013 07:28:50 -0700 [thread overview]
Message-ID: <518A6122.5060309@linux.intel.com> (raw)
In-Reply-To: <1368013438-15107-2-git-send-email-marcin.juszkiewicz@linaro.org>
On 05/08/2013 04:43 AM, Marcin Juszkiewicz wrote:
> Signed-off-by: Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>
> ---
> meta/recipes-devtools/gdb/gdb-7.6.inc | 11 ++++++++++
> .../gdb/gdb-7.6/gdbserver-cflags-last.diff | 25 ++++++++++++++++++++++
> .../recipes-devtools/gdb/gdb-cross-canadian_7.6.bb | 5 +++++
> meta/recipes-devtools/gdb/gdb-cross_7.6.bb | 4 ++++
> meta/recipes-devtools/gdb/gdb_7.6.bb | 3 +++
> 5 files changed, 48 insertions(+)
> create mode 100644 meta/recipes-devtools/gdb/gdb-7.6.inc
> create mode 100644 meta/recipes-devtools/gdb/gdb-7.6/gdbserver-cflags-last.diff
> create mode 100644 meta/recipes-devtools/gdb/gdb-cross-canadian_7.6.bb
> create mode 100644 meta/recipes-devtools/gdb/gdb-cross_7.6.bb
> create mode 100644 meta/recipes-devtools/gdb/gdb_7.6.bb
>
Why are you keeping the previous version, OE-Core mostly takes Updates
to recipes unless there is strong reason to keep the old version around.
I also note that Bogdan provided such an update, but might have other issues
Sau!
> diff --git a/meta/recipes-devtools/gdb/gdb-7.6.inc b/meta/recipes-devtools/gdb/gdb-7.6.inc
> new file mode 100644
> index 0000000..20c4ea1
> --- /dev/null
> +++ b/meta/recipes-devtools/gdb/gdb-7.6.inc
> @@ -0,0 +1,11 @@
> +LICENSE="GPLv2 & GPLv3 & LGPLv2 & LGPLv3"
> +LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
> + file://COPYING3;md5=d32239bcb673463ab874e80d47fae504 \
> + file://COPYING3.LIB;md5=6a6a8e020838b23406c81b19c1d46df6 \
> + file://COPYING.LIB;md5=9f604d8a4f8e74f4f5140845a21b6674"
> +
> +PR = "${INC_PR}.0"
> +S = "${WORKDIR}/${BPN}-${PV}"
> +
> +SRC_URI[md5sum] = "a9836707337e5f7bf76a009a8904f470"
> +SRC_URI[sha256sum] = "8070389a5dcc104eb0be483d582729f98ed4d761ad19cedd3f17b5d2502faa36"
> diff --git a/meta/recipes-devtools/gdb/gdb-7.6/gdbserver-cflags-last.diff b/meta/recipes-devtools/gdb/gdb-7.6/gdbserver-cflags-last.diff
> new file mode 100644
> index 0000000..4dfc419
> --- /dev/null
> +++ b/meta/recipes-devtools/gdb/gdb-7.6/gdbserver-cflags-last.diff
> @@ -0,0 +1,25 @@
> +Upstream-Status: Pending
> +
> +---
> + gdb/gdbserver/Makefile.in | 4 ++--
> + 1 file changed, 2 insertions(+), 2 deletions(-)
> +
> +--- gdb/gdbserver/Makefile.in.orig
> ++++ gdb/gdbserver/Makefile.in
> +@@ -118,14 +118,14 @@ WARN_CFLAGS_NO_FORMAT = `echo " $(WARN_C
> + # CFLAGS is specifically reserved for setting from the command line
> + # when running make. I.E. "make CFLAGS=-Wmissing-prototypes".
> + CFLAGS = @CFLAGS@
> +
> + # INTERNAL_CFLAGS is the aggregate of all other *CFLAGS macros.
> +-INTERNAL_CFLAGS_BASE = ${CFLAGS} ${GLOBAL_CFLAGS} \
> ++INTERNAL_CFLAGS_BASE = ${GLOBAL_CFLAGS} \
> + ${PROFILE_CFLAGS} ${INCLUDE_CFLAGS}
> + INTERNAL_WARN_CFLAGS = ${INTERNAL_CFLAGS_BASE} $(WARN_CFLAGS)
> +-INTERNAL_CFLAGS = ${INTERNAL_WARN_CFLAGS} $(WERROR_CFLAGS) -DGDBSERVER
> ++INTERNAL_CFLAGS = ${INTERNAL_WARN_CFLAGS} $(WERROR_CFLAGS) ${CFLAGS} -DGDBSERVER
> +
> + # LDFLAGS is specifically reserved for setting from the command line
> + # when running make.
> + LDFLAGS = @LDFLAGS@
> + INTERNAL_LDFLAGS = $(LDFLAGS) @RDYNAMIC@
> diff --git a/meta/recipes-devtools/gdb/gdb-cross-canadian_7.6.bb b/meta/recipes-devtools/gdb/gdb-cross-canadian_7.6.bb
> new file mode 100644
> index 0000000..a2194a1
> --- /dev/null
> +++ b/meta/recipes-devtools/gdb/gdb-cross-canadian_7.6.bb
> @@ -0,0 +1,5 @@
> +require gdb-common.inc
> +require gdb-cross-canadian.inc
> +require gdb-7.6.inc
> +
> +GDBPROPREFIX = "--program-prefix='${TARGET_PREFIX}'"
> diff --git a/meta/recipes-devtools/gdb/gdb-cross_7.6.bb b/meta/recipes-devtools/gdb/gdb-cross_7.6.bb
> new file mode 100644
> index 0000000..62f6937
> --- /dev/null
> +++ b/meta/recipes-devtools/gdb/gdb-cross_7.6.bb
> @@ -0,0 +1,4 @@
> +require gdb-cross.inc
> +require gdb-7.6.inc
> +
> +SRC_URI += "file://sim-install-6.6.patch"
> diff --git a/meta/recipes-devtools/gdb/gdb_7.6.bb b/meta/recipes-devtools/gdb/gdb_7.6.bb
> new file mode 100644
> index 0000000..0c9818d
> --- /dev/null
> +++ b/meta/recipes-devtools/gdb/gdb_7.6.bb
> @@ -0,0 +1,3 @@
> +require gdb.inc
> +require gdb-7.6.inc
> +
>
next prev parent reply other threads:[~2013-05-08 14:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 11:43 [PATCH 1/4] gdb: AArch64 lacks lttng support Marcin Juszkiewicz
2013-05-08 11:43 ` [PATCH 2/4] gdb: add 7.6 version Marcin Juszkiewicz
2013-05-08 14:28 ` Saul Wold [this message]
2013-05-09 8:48 ` [PATCH v2 1/3] " Marcin Juszkiewicz
2013-05-09 8:48 ` [PATCH v2 2/3] gdb: checksums are in versioned include Marcin Juszkiewicz
2013-05-09 8:48 ` [PATCH v2 3/3] gdb-cross-canadian: set everything in gdb-cross-canadian.inc Marcin Juszkiewicz
2013-05-09 4:36 ` [PATCH 2/4] gdb: add 7.6 version Khem Raj
2013-05-08 11:43 ` [PATCH 3/4] gdb: move checksums to versioned include Marcin Juszkiewicz
2013-05-09 4:37 ` Khem Raj
2013-05-09 7:42 ` Richard Purdie
2013-05-09 7:56 ` Khem Raj
2013-05-08 11:43 ` [PATCH 4/4] gdb: tabs -> spaces Marcin Juszkiewicz
2013-05-09 4:37 ` Khem Raj
2013-05-09 4:36 ` [PATCH 1/4] gdb: AArch64 lacks lttng support Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518A6122.5060309@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=bogdan.a.marinescu@intel.com \
--cc=marcin.juszkiewicz@linaro.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.