All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfstests: fix incorrect redirect in generic/233
Date: Wed, 08 May 2013 09:34:13 -0500	[thread overview]
Message-ID: <518A6265.5040404@sandeen.net> (raw)
In-Reply-To: <1367993066-9313-2-git-send-email-david@fromorbit.com>

On 5/8/13 1:04 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> generic/233 attempts to direct output to tee, but instead of using a
> pipe it uses an append operator. Hence it leaves a file named "tee"
> in the root directory of the xfstests execution path. Just direct
> the output to the $seqres.full file rather than trying to tee it
> into the test output as well.
> 
> Reported-by: "Michael L. Semon" <mlsemon35@gmail.com>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Reviewed-by: Eric Sandeen <sandeen@redhat.com>

> ---
>  tests/generic/233 |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/generic/233 b/tests/generic/233
> index 2b6cd2f..58b3672 100755
> --- a/tests/generic/233
> +++ b/tests/generic/233
> @@ -62,7 +62,7 @@ _fsstress()
>  -f rename=10 -f fsync=2 -f write=15 -f dwrite=15 \
>  -n $count -d $out -p 7`
>  
> -	echo "fsstress $args" >> tee -a $seqres.full
> +	echo "fsstress $args" >> $seqres.full
>  	if ! su $qa_user -c "$FSSTRESS_PROG $args" | tee -a $seqres.full | _filter_num
>  	then
>  		echo "    fsstress $args returned $?"
> 

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-05-08 14:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08  6:04 [PATCH 0/2] xfstests: more simple fixes Dave Chinner
2013-05-08  6:04 ` [PATCH 1/2] xfstests: fix incorrect redirect in generic/233 Dave Chinner
2013-05-08 14:34   ` Eric Sandeen [this message]
2013-05-14 13:47   ` Rich Johnston
2013-05-08  6:04 ` [PATCH 2/2] xfstests: quota not supported on realtime filesystems Dave Chinner
2013-05-08 14:37   ` Eric Sandeen
2013-05-08 23:34     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518A6265.5040404@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.