From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Date: Wed, 08 May 2013 15:15:17 +0000 Subject: Re: [PATCH] irqchip: Add irqchip_init dummy function Message-Id: <518A6C05.9030303@cogentembedded.com> List-Id: References: <1368019204-24448-1-git-send-email-hechtb+renesas@gmail.com> In-Reply-To: <1368019204-24448-1-git-send-email-hechtb+renesas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org Hello. On 08-05-2013 17:20, Bastian Hecht wrote: > We add an empty irqchip_init dummy function for cases in which > CONFIG_IRQCHIP is not used. In these cases irqchip.c is not compiled, > but a funtion call may still be present in architecture code, that in > runtime doesn't get hit. > E.g. this is needed in the arch/arm/mach-shmobile/intc-r8a7740.c > interrupt setup code where OF use and non OF us is both handled in one > file. > Signed-off-by: Bastian Hecht > --- > include/linux/irqchip.h | 4 ++++ > 1 file changed, 4 insertions(+) > diff --git a/include/linux/irqchip.h b/include/linux/irqchip.h > index e0006f1..78527ba 100644 > --- a/include/linux/irqchip.h > +++ b/include/linux/irqchip.h > @@ -11,6 +11,10 @@ > #ifndef _LINUX_IRQCHIP_H > #define _LINUX_IRQCHIP_H > > +#ifdef CONFIG_IRQCHIP > void irqchip_init(void); > +#else > +void irqchip_init(void) {}; Semicolon not needed here. > +#endif WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov) Date: Wed, 08 May 2013 19:15:17 +0400 Subject: [PATCH] irqchip: Add irqchip_init dummy function In-Reply-To: <1368019204-24448-1-git-send-email-hechtb+renesas@gmail.com> References: <1368019204-24448-1-git-send-email-hechtb+renesas@gmail.com> Message-ID: <518A6C05.9030303@cogentembedded.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 08-05-2013 17:20, Bastian Hecht wrote: > We add an empty irqchip_init dummy function for cases in which > CONFIG_IRQCHIP is not used. In these cases irqchip.c is not compiled, > but a funtion call may still be present in architecture code, that in > runtime doesn't get hit. > E.g. this is needed in the arch/arm/mach-shmobile/intc-r8a7740.c > interrupt setup code where OF use and non OF us is both handled in one > file. > Signed-off-by: Bastian Hecht > --- > include/linux/irqchip.h | 4 ++++ > 1 file changed, 4 insertions(+) > diff --git a/include/linux/irqchip.h b/include/linux/irqchip.h > index e0006f1..78527ba 100644 > --- a/include/linux/irqchip.h > +++ b/include/linux/irqchip.h > @@ -11,6 +11,10 @@ > #ifndef _LINUX_IRQCHIP_H > #define _LINUX_IRQCHIP_H > > +#ifdef CONFIG_IRQCHIP > void irqchip_init(void); > +#else > +void irqchip_init(void) {}; Semicolon not needed here. > +#endif WBR, Sergei