From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH V2 23/33] xen/arm: Allow Xen to run on multiple platform without recompilation Date: Wed, 08 May 2013 17:38:42 +0100 Message-ID: <518A7F92.5080302@linaro.org> References: <1368027124.17285.34.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1368027124.17285.34.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Stefano Stabellini , "patches@linaro.org" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 05/08/2013 04:32 PM, Ian Campbell wrote: > On Wed, 2013-05-08 at 03:33 +0100, Julien Grall wrote: >> diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c >> index bfc41c2..1114fe7 100644 >> --- a/xen/arch/arm/time.c >> +++ b/xen/arch/arm/time.c >> @@ -33,6 +33,7 @@ >> #include >> #include >> #include >> +#include >> >> /* >> * Unfortunately the hypervisor timer interrupt appears to be buggy in >> @@ -130,6 +131,11 @@ int __init init_xen_time(void) >> panic("CPU does not support the Generic Timer v1 interface.\n"); >> >> cpu_khz = READ_SYSREG32(CNTFRQ_EL0) / 1000; > > Might be better to read this after platform_init_time, in case p_i_t > does something "magic" on this platform? Ok. I will move the platform_init_time just before. -- Julien