From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH V2 21/33] xen/arm: Use device tree API in pl011 UART driver Date: Wed, 08 May 2013 17:55:11 +0100 Message-ID: <518A836F.1050902@linaro.org> References: <651d1e6d364d53a3f09c77f086a0a36c15e068c3.1367979526.git.julien.grall@linaro.org> <1368026240.17285.23.camel@zakaz.uk.xensource.com> <518A7C0B.7010500@linaro.org> <1368031418.17285.48.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1368031418.17285.48.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Stefano Stabellini , "patches@linaro.org" , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 05/08/2013 05:43 PM, Ian Campbell wrote: > On Wed, 2013-05-08 at 17:23 +0100, Julien Grall wrote: >>> That does then call into question the whole serial_arm_defaults thing. >>> Perhaps index should just be the order in which they are registered (and >>> at the moment it is effectively hardcoded to 0 anyway) >> >> >> I'm thinking about using serial_arm_defaults for baud rate,... For the >> moment the different values are hardcoded. >> >> {arm,dt}_init_uart will parse the dtuart parameters on the command line >> and then fill serial_arm_defaults. > > Perhaps instead of &serial_arm_defaults you should pass a char * pointer > to opt_dtuart? This would allow for per-device settings and is > consistent with the ns16550 driver. Ok. I will modify it in the next patch series. -- Julien