From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas KANDAGATLA Subject: Re: [RFC 1/8] serial:st-asc: Add ST ASC driver. Date: Wed, 08 May 2013 19:18:02 +0100 Message-ID: <518A96DA.5060809@st.com> References: <1368022187-1633-1-git-send-email-srinivas.kandagatla@st.com> <1368022248-2153-1-git-send-email-srinivas.kandagatla@st.com> <201305081634.43498.arnd@arndb.de> <20130508143908.GJ24282@game.jcrosoft.org> Reply-To: srinivas.kandagatla@st.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20130508143908.GJ24282@game.jcrosoft.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jean-Christophe PLAGNIOL-VILLARD Cc: Mark Brown , Russell King , Samuel Ortiz , Arnd Bergmann , linux-doc@vger.kernel.org, Viresh Kumar , devicetree-discuss@lists.ozlabs.org, Nicolas Pitre , Will Deacon , Stephen Gallimore , Rob Herring , linux-kernel@vger.kernel.org, Stuart Menefy , linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, Stephen Warren , Dong Aisheng , jslaby@suse.cz, linux-arm-kernel@lists.infradead.org, Jason Cooper List-Id: linux-serial@vger.kernel.org On 08/05/13 15:39, Jean-Christophe PLAGNIOL-VILLARD wrote: >>> + >> > >> > Please remove all forward declarations, by reordering the functions in >> > the way they are called. >> > > and drop the dummy functions We can not remove the dummy functions, as the serial-core does not check it before using them. >> > >>> > > diff --git a/drivers/tty/serial/st-asc.h b/drivers/tty/serial/st-asc.h >>> > > new file mode 100644 >>> > > index 0000000..e59f818 >>> > > --- /dev/null >>> > > +++ b/drivers/tty/serial/st-asc.h From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas.kandagatla@st.com (Srinivas KANDAGATLA) Date: Wed, 08 May 2013 19:18:02 +0100 Subject: [RFC 1/8] serial:st-asc: Add ST ASC driver. In-Reply-To: <20130508143908.GJ24282@game.jcrosoft.org> References: <1368022187-1633-1-git-send-email-srinivas.kandagatla@st.com> <1368022248-2153-1-git-send-email-srinivas.kandagatla@st.com> <201305081634.43498.arnd@arndb.de> <20130508143908.GJ24282@game.jcrosoft.org> Message-ID: <518A96DA.5060809@st.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/05/13 15:39, Jean-Christophe PLAGNIOL-VILLARD wrote: >>> + >> > >> > Please remove all forward declarations, by reordering the functions in >> > the way they are called. >> > > and drop the dummy functions We can not remove the dummy functions, as the serial-core does not check it before using them. >> > >>> > > diff --git a/drivers/tty/serial/st-asc.h b/drivers/tty/serial/st-asc.h >>> > > new file mode 100644 >>> > > index 0000000..e59f818 >>> > > --- /dev/null >>> > > +++ b/drivers/tty/serial/st-asc.h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758107Ab3EHSXb (ORCPT ); Wed, 8 May 2013 14:23:31 -0400 Received: from eu1sys200aog116.obsmtp.com ([207.126.144.141]:58666 "EHLO eu1sys200aog116.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757747Ab3EHSX3 (ORCPT ); Wed, 8 May 2013 14:23:29 -0400 Message-ID: <518A96DA.5060809@st.com> Date: Wed, 08 May 2013 19:18:02 +0100 From: Srinivas KANDAGATLA Reply-To: srinivas.kandagatla@st.com Organization: STMicroelectronics User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Jean-Christophe PLAGNIOL-VILLARD Cc: Arnd Bergmann , linux-doc@vger.kernel.org, Viresh Kumar , Will Deacon , jslaby@suse.cz, Russell King , Samuel Ortiz , Nicolas Pitre , Stephen Gallimore , linux-serial@vger.kernel.org, Jason Cooper , devicetree-discuss@lists.ozlabs.org, Rob Herring , Stuart Menefy , Stephen Warren , Dong Aisheng , linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [RFC 1/8] serial:st-asc: Add ST ASC driver. References: <1368022187-1633-1-git-send-email-srinivas.kandagatla@st.com> <1368022248-2153-1-git-send-email-srinivas.kandagatla@st.com> <201305081634.43498.arnd@arndb.de> <20130508143908.GJ24282@game.jcrosoft.org> In-Reply-To: <20130508143908.GJ24282@game.jcrosoft.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/05/13 15:39, Jean-Christophe PLAGNIOL-VILLARD wrote: >>> + >> > >> > Please remove all forward declarations, by reordering the functions in >> > the way they are called. >> > > and drop the dummy functions We can not remove the dummy functions, as the serial-core does not check it before using them. >> > >>> > > diff --git a/drivers/tty/serial/st-asc.h b/drivers/tty/serial/st-asc.h >>> > > new file mode 100644 >>> > > index 0000000..e59f818 >>> > > --- /dev/null >>> > > +++ b/drivers/tty/serial/st-asc.h