From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex) Date: Thu, 09 May 2013 02:23:52 +0200 Message-ID: <518AEC98.4070507@intel.com> References: <20130506125937.GA14036@phenom.dumpdata.com> <20130507190024.GA4303@phenom.dumpdata.com> <20130508125414.GB30955@pd.tnic> <20130508140342.GA8152@phenom.dumpdata.com> <20130508142949.GC30955@pd.tnic> <20130508163249.GB369@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com ([143.182.124.37]:18561 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982Ab3EIAX7 (ORCPT ); Wed, 8 May 2013 20:23:59 -0400 In-Reply-To: <20130508163249.GB369@phenom.dumpdata.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: Konrad Rzeszutek Wilk Cc: Borislav Petkov , toshi.kani@hp.com, prarit@redhat.com, isimatu.yasuaki@jp.fujitsu.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, fenghua.yu@intel.com, xen-devel@lists.xensource.com, linux-acpi@vger.kernel.org T24gNS84LzIwMTMgNjozMiBQTSwgS29ucmFkIFJ6ZXN6dXRlayBXaWxrIHdyb3RlOgo+IE9uIFdl ZCwgTWF5IDA4LCAyMDEzIGF0IDA0OjI5OjQ5UE0gKzAyMDAsIEJvcmlzbGF2IFBldGtvdiB3cm90 ZToKPj4gT24gV2VkLCBNYXkgMDgsIDIwMTMgYXQgMTA6MDM6NDJBTSAtMDQwMCwgS29ucmFkIFJ6 ZXN6dXRlayBXaWxrIHdyb3RlOgo+Pgo+PiBbIOKApiBzbmlwIHNvbWUgZnVua3kgQklPUyBjb2Rl IF0KPj4KPj4+IFtoZXJlIGl0IHNoaWZ0cyBhbmQgY29udGludWVzIG9uIHRlc3RpbmcgZWFjaCBD UFUgYml0XQo+Pj4KPj4+PiBRdWVzdGlvbnMgb3ZlciBxdWVzdGlvbnMuLi4/Cj4+PiBJIHByb2Jh Ymx5IHdlbnQgb3ZlcmJvYXJkIHdpdGggbXkgYW5zd2VycyA6LSkKPj4gS29ucmFkLCB5b3UncmUg a2lsbGluZyBtZSEgOi0pIFlvdSBhY3R1YWxseSB3ZW50IGFuZCBsb29rZWQgYXQgdGhlCj4+IEJJ T1MgZGlzYXNzZW1ibHkgdm9sdW50YXJpbHkuIFlvdSBtdXN0IGJlIGluc2FuZSwgSSB0aGluayB5 b3Ugc2hvdWxkCj4+IGltbWVkaWF0ZWx5IGdvIHRvIHRoZSBkb2N0b3Igbm93IGZvciBhIHRob3Jv dWdoIGNoZWNrdXAuIDotKQo+Pgo+PiBJIHRoaW5rIEkga25vdyB3aG8gSSBjYW4gc2xpbmcgQklP UyBpc3N1ZXMgbm93IHRvLgo+IEdyZWF0IC4uIDotKQo+Pj4+IExvb2tzIGxpa2Ugc2F2ZV9tY19m b3JfZWFybHkgd291bGQgbmVlZCBhbm90aGVyLCBsb2NhbCBtdXRleCB0byBmaXggdGhhdC4KPj4+ IExldCBtZSB0cnkgdGhhdC4gVGhhbmtzIGZvciB0aGUgc3VnZ2VzdGlvbi4KPj4gT2ssIHNlcmlv dXNseSBub3c6IHllYWgsIHRoaXMgd2FzIGp1c3QgYW4gaWRlYSwgaXQgc2hvdWxkIGF0IGxlYXN0 IGdldAo+PiB0aGUgbmVzdGluZyBvdXQgb2YgdGhlIHdheS4KPj4KPj4gQWJvdXQgdGhlIEJJT1Mg ZGVhbDogeW91J3JlIHByb2JhYmx5IHN0YXJpbmcgYXQgc29tZSBCSU9TIG91dCB0aGVyZQo+PiBi dXQgaXMgdGhpcyB0aGUgd2F5IHRoYXQgaXQgaXMgYWN0dWFsbHkgZ29pbmcgdG8gYmUgaW1wbGVt ZW50ZWQgb24KPj4gdGhlIHBoeXNpY2FsIGhvdHBsdWcgQklPUz8gSSBtZWFuLCBJJ3ZlIG9ubHkg aGVhcmQgcnVtb3JzIGFib3V0IElWQgo+PiBzdXBwb3J0aW5nIHBoeXNpY2FsIGhvdHBsdWcgYnV0 IGRvIHlvdSBldmVuIGhhdmUgYWNjZXNzIHRvIHN1Y2ggQklPUyB0bwo+PiB2ZXJpZnk/Cj4gVW5m b3J0dW5hdGx5IG5vdC4gSSBhbSBnZXR0aW5nIGFuIEl2eVRvd24gYm94IHNvIGhvcGVmdWxseSB0 aGF0IGhhcyB0aGlzCj4gc3VwcG9ydC4gQnV0IEkgdGhvdWdodCB0aGF0IEZlbmdodWEgZGlkIHNp bmNlIGhlIG1lbnRpb25lZCBpbiB0aGUgcGF0Y2guCj4KPiBCZXNpZGVzIHRoYXQgSSB0aGluayB0 aGlzIGNhbiBhbHNvIGFwcGVhciBvbiBWTVdhcmUgaWYgb25lIGlzIGRvaW5nCj4gQ1BVIGhvdHBs dWcgYW5kIG9uIHNvbWUgSFAgbWFjaGluZXMgLSBsZXQgbWUgQ0MgdGhlIHJlbGV2YW50IHBlb3Bs ZQo+IGV4dHJhY3RlZCBmcm9tIGRyaXZlcnMvYWNwaS9wcm9jZXNzb3JfZHJpdmVyLmMuCj4gKHNl ZSAgaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMTMvNS83LzU4OCBmb3IgdGhlIHRocmVhZCkKPgo+ IFJhZmFlbCwgZG8geW91IGtub3cgb2YgYW55IHNwZWNpZmljIEludGVsIGhhcmR3YXJlIHRoYXQg aGFzIHRoaXMgaW1wbGVtZW50ZWQ/CgpObywgSSBkb24ndCBoYXZlIHRoaXMgaW5mb3JtYXRpb24u CgpCeSB0aGUgd2F5LCBoZXJlJ3MgYSBnZW5lcmFsIHJlcXVlc3QuCgpQbGVhc2UgQ0MgYW55IG1l c3NhZ2VzIGhhdmluZyB0aGUgd29yZCAiQUNQSSIgYW55d2hlcmUgaW4gdGhlIGJvZHkgb3IgCnN1 YmplY3QgdG8gbGludXgtYWNwaUB2Z2VyLmtlcm5lbC5vcmcuICBJJ20gcmVhbGx5IHRpcmVkIG9m IGNoYXNpbmcgCkFDUEktcmVsYXRlZCB0aHJlYWRzIG9uIHRoZSBMS01MIGp1c3QgYmVjYXVzZSBw ZW9wbGUgZG9uJ3QgY2FyZSBhYm91dCAKQ0NpbmcgcmVsZXZhbnQgbGlzdHMgYW5kIEknbSBnb2lu ZyB0byBOQUsgYWxsIHBhdGNoZXMgdG91Y2hpbmcgQUNQSSBpbiAKYW55IHdheSBpZiB0aGV5IGhh dmVuJ3QgYmVlbiBDQ2VkIHRvIHRoZSBBQ1BJIGxpc3QuICBTZXJpb3VzbHkuCgpUaGlzIHBhcnRp Y3VsYXIgaXRlbSBtYXkgb3IgbWF5IG5vdCBjb25mbGljdCB3aXRoIHNvbWUgb25nb2luZyB3b3Jr IAp0YWtpbmcgcGxhY2UgaW4gdGhlcmUgKGFuZCBwYXRjaGVzIHByZXNlbnQgaW4gbXkgdHJlZSku CgpBbmQgeW91J3ZlIGFscmVhZHkgaGFkIHByb2JsZW1zIHdpdGggQUNQSS1yZWxhdGVkIGNvZGUg Y29uZmxpY3RzLCBzbyAKdGhhdCdzIG5vdCBsaWtlIGl0J3MgbmV2ZXIgaGFwcGVuZWQuCgpUaGFu a3MsClJhZmFlbAoKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkludGVsIFRlY2hub2xvZ3kgUG9sYW5kIHNwLiB6IG8u by4KeiBzaWVkemliYSB3IEdkYW5za3UKdWwuIFNsb3dhY2tpZWdvIDE3Mwo4MC0yOTggR2RhbnNr CgpTYWQgUmVqb25vd3kgR2RhbnNrIFBvbG5vYyB3IEdkYW5za3UsIApWSUkgV3lkemlhbCBHb3Nw b2RhcmN6eSBLcmFqb3dlZ28gUmVqZXN0cnUgU2Fkb3dlZ28sIApudW1lciBLUlMgMTAxODgyCgpO SVAgOTU3LTA3LTUyLTMxNgpLYXBpdGFsIHpha2xhZG93eSAyMDAuMDAwIHpsCgpUaGlzIGUtbWFp bCBhbmQgYW55IGF0dGFjaG1lbnRzIG1heSBjb250YWluIGNvbmZpZGVudGlhbCBtYXRlcmlhbCBm b3IKdGhlIHNvbGUgdXNlIG9mIHRoZSBpbnRlbmRlZCByZWNpcGllbnQocykuIEFueSByZXZpZXcg b3IgZGlzdHJpYnV0aW9uCmJ5IG90aGVycyBpcyBzdHJpY3RseSBwcm9oaWJpdGVkLiBJZiB5b3Ug YXJlIG5vdCB0aGUgaW50ZW5kZWQKcmVjaXBpZW50LCBwbGVhc2UgY29udGFjdCB0aGUgc2VuZGVy IGFuZCBkZWxldGUgYWxsIGNvcGllcy4K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754150Ab3EIAYB (ORCPT ); Wed, 8 May 2013 20:24:01 -0400 Received: from mga14.intel.com ([143.182.124.37]:18561 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982Ab3EIAX7 (ORCPT ); Wed, 8 May 2013 20:23:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,638,1363158000"; d="scan'208";a="238830210" Message-ID: <518AEC98.4070507@intel.com> Date: Thu, 09 May 2013 02:23:52 +0200 From: "Rafael J. Wysocki" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Konrad Rzeszutek Wilk CC: Borislav Petkov , toshi.kani@hp.com, prarit@redhat.com, isimatu.yasuaki@jp.fujitsu.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, fenghua.yu@intel.com, xen-devel@lists.xensource.com, linux-acpi@vger.kernel.org Subject: Re: v3.9 - CPU hotplug and microcode earlier loading hits a mutex deadlock (x86_cpu_hotplug_driver_mutex) References: <20130506125937.GA14036@phenom.dumpdata.com> <20130507190024.GA4303@phenom.dumpdata.com> <20130508125414.GB30955@pd.tnic> <20130508140342.GA8152@phenom.dumpdata.com> <20130508142949.GC30955@pd.tnic> <20130508163249.GB369@phenom.dumpdata.com> In-Reply-To: <20130508163249.GB369@phenom.dumpdata.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r490OEqo012725 On 5/8/2013 6:32 PM, Konrad Rzeszutek Wilk wrote: > On Wed, May 08, 2013 at 04:29:49PM +0200, Borislav Petkov wrote: >> On Wed, May 08, 2013 at 10:03:42AM -0400, Konrad Rzeszutek Wilk wrote: >> >> [ … snip some funky BIOS code ] >> >>> [here it shifts and continues on testing each CPU bit] >>> >>>> Questions over questions...? >>> I probably went overboard with my answers :-) >> Konrad, you're killing me! :-) You actually went and looked at the >> BIOS disassembly voluntarily. You must be insane, I think you should >> immediately go to the doctor now for a thorough checkup. :-) >> >> I think I know who I can sling BIOS issues now to. > Great .. :-) >>>> Looks like save_mc_for_early would need another, local mutex to fix that. >>> Let me try that. Thanks for the suggestion. >> Ok, seriously now: yeah, this was just an idea, it should at least get >> the nesting out of the way. >> >> About the BIOS deal: you're probably staring at some BIOS out there >> but is this the way that it is actually going to be implemented on >> the physical hotplug BIOS? I mean, I've only heard rumors about IVB >> supporting physical hotplug but do you even have access to such BIOS to >> verify? > Unfortunatly not. I am getting an IvyTown box so hopefully that has this > support. But I thought that Fenghua did since he mentioned in the patch. > > Besides that I think this can also appear on VMWare if one is doing > CPU hotplug and on some HP machines - let me CC the relevant people > extracted from drivers/acpi/processor_driver.c. > (see https://lkml.org/lkml/2013/5/7/588 for the thread) > > Rafael, do you know of any specific Intel hardware that has this implemented? No, I don't have this information. By the way, here's a general request. Please CC any messages having the word "ACPI" anywhere in the body or subject to linux-acpi@vger.kernel.org. I'm really tired of chasing ACPI-related threads on the LKML just because people don't care about CCing relevant lists and I'm going to NAK all patches touching ACPI in any way if they haven't been CCed to the ACPI list. Seriously. This particular item may or may not conflict with some ongoing work taking place in there (and patches present in my tree). And you've already had problems with ACPI-related code conflicts, so that's not like it's never happened. Thanks, Rafael --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. z siedziba w Gdansku ul. Slowackiego 173 80-298 Gdansk Sad Rejonowy Gdansk Polnoc w Gdansku, VII Wydzial Gospodarczy Krajowego Rejestru Sadowego, numer KRS 101882 NIP 957-07-52-316 Kapital zakladowy 200.000 zl This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I