All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
To: Eric Blake <eblake@redhat.com>
Cc: "kwolf@redhat.com" <kwolf@redhat.com>,
	wdongxu@cn.ibm.com, qemu-devel@nongnu.org, stefanha@redhat.com,
	armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH V14 6/6] remove QEMUOptionParameter related functions and struct
Date: Thu, 09 May 2013 10:19:36 +0800	[thread overview]
Message-ID: <518B07B8.8020207@linux.vnet.ibm.com> (raw)
In-Reply-To: <518A9286.2040603@redhat.com>

On 2013/5/9 1:59, Eric Blake wrote:
> [assuming you mis-typed your cc:, and that you meant kwolf instead of
> kwol at redhat]
>
> On 05/08/2013 02:45 AM, Dong Xu Wang wrote:
>> Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
>> ---
>>   include/qemu/option.h |  32 ------
>>   util/qemu-option.c    | 285 -----	---------------------------------------------
>>   2 files changed, 317 deletions(-)
>>
>> diff --git a/include/qemu/option.h b/include/qemu/option.h
>> index d63e447..51814cf 100644
>> --- a/include/qemu/option.h
>> +++ b/include/qemu/option.h
>> @@ -38,17 +38,6 @@ enum QEMUOptionParType {
>>       OPT_STRING,
>>   };
>>
>> -typedef struct QEMUOptionParameter {
>> -    const char *name;
>> -    enum QEMUOptionParType type;
>
> 'enum QEMUOptionParType' several lines earlier is now unused; you should
> clean that too.
>
Yes, will remove it after reviewing, thank you, Eric.

      reply	other threads:[~2013-05-09  2:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08  8:45 [Qemu-devel] [PATCH V14 0/6] replace QEMUOptionParameter with QemuOpts parser Dong Xu Wang
2013-05-08  8:45 ` [Qemu-devel] [PATCH V14 1/6] add def_value_str in QemuOptDesc struct and rewrite qemu_opts_print Dong Xu Wang
2013-05-08  8:45 ` [Qemu-devel] [PATCH V14 2/6] avoid duplication of default value in QemuOpts Dong Xu Wang
2013-05-08  8:45 ` [Qemu-devel] [PATCH V14 3/6] Create four QemuOptsList related functions Dong Xu Wang
2013-05-08  8:45 ` [Qemu-devel] [PATCH V14 4/6] Create some QemuOpts functons Dong Xu Wang
2013-05-08  8:45 ` [Qemu-devel] [PATCH V14 5/6] Use QemuOpts support in block layer Dong Xu Wang
2013-05-08  8:45 ` [Qemu-devel] [PATCH V14 6/6] remove QEMUOptionParameter related functions and struct Dong Xu Wang
2013-05-08 17:59   ` Eric Blake
2013-05-09  2:19     ` Dong Xu Wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518B07B8.8020207@linux.vnet.ibm.com \
    --to=wdongxu@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=wdongxu@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.