From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [Xen-devel] lguest: unhandled trap 13 and CONFIG_MICROCODE_INTEL_EARLY Date: Wed, 08 May 2013 20:24:50 -0700 Message-ID: <518B1702.7010307@zytor.com> References: <1367450300.11532.32.camel@x61.thuisdomein> <87li7srb3r.fsf@rustcorp.com.au> <5187C369.5020902@zytor.com> <87mws7nzag.fsf@rustcorp.com.au> <20130508172040.GA1256@phenom.dumpdata.com> <8738txnd13.fsf@rustcorp.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <8738txnd13.fsf-8n+1lVoiYb80n/F98K4Iww@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: lguest-bounces+glkvl-lguest=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "Lguest" To: Rusty Russell Cc: lguest-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Konrad Rzeszutek Wilk , Jeremy Fitzhardinge , xen-devel-GuqFBffKawuULHF6PoxzQEEOCMrvLtNR@public.gmane.org, Thomas Gleixner , Ingo Molnar List-Id: xen-devel@lists.xenproject.org On 05/08/2013 06:43 PM, Rusty Russell wrote: > > OK, that confirms my understanding it's lguest-only. > > To return to the immediate proposal: I'd like to expand it KEEP_SEGMENTS > to say "don't do any privileged ops before the platform entry point" > which is what it used to do (before we added those config options), and > still does (if they're disabled). > > This fixes lguest for those configs, and if there *are* any other users, > this just means they don't support OLPC machines (since 2.6.37) or early > microcode (3.9). OLPC + KEEP_SEGMENTS is vanishingly unlikely (the OLPC > bootloader doesn't use it), and early microcode never worked with > paravirt anyway (those native_cpuid() calls). > > Failing that, second best to remove KEEP_SEGMENTS, and have lguest > 'emulate' (ie. skip!) those instructions. We already do this for in/out > instructions, see drivers/lguest/x86/core.c emulate_insn(). More code, > but it's lguest code. > Or we can skip the microcode stuff for platform == 2. -hpa