All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: lvm-devel@redhat.com
Subject: [PATCH 05/19] lvm2app: Move core lv re-size code (v2)
Date: Thu, 09 May 2013 09:13:26 +0200	[thread overview]
Message-ID: <518B4C96.5020601@redhat.com> (raw)
In-Reply-To: <1368053141-13836-6-git-send-email-tasleson@redhat.com>

Dne 9.5.2013 00:45, Tony Asleson napsal(a):
> Moved to allow use from command line and for library use.
>
> Signed-off-by: Tony Asleson <tasleson@redhat.com>
> ---
>   lib/metadata/lv_manip.c          | 734 +++++++++++++++++++++++++++++++++++++
>   lib/metadata/metadata-exported.h |  46 +++
>   tools/lvresize.c                 | 773 +--------------------------------------
>   3 files changed, 781 insertions(+), 772 deletions(-)
>
> diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
> index 42e0fab..587cbd2 100644
> --- a/lib/metadata/lv_manip.c
> +++ b/lib/metadata/lv_manip.c
> @@ -27,6 +27,8 @@
>   #include "activate.h"
>   #include "str_list.h"
>   #include "defaults.h"
> +#include "lvm-exec.h"
> +#include "errors.h"
>

This '/tools' error from   '/lib'  needs some solution.

Currently /lib reports  1 success, 0 error - and potential error state is
returned via some other mechanism (i.e. setting struct member...)

On the other hand the lvm2app is seriously missing error reporting - since
the user of this API is usually not seeing typical lvm2 log_error messages.

Zdenek



  reply	other threads:[~2013-05-09  7:13 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08 22:45 [PATCH 00/19] Looking for reviews Tony Asleson
2013-05-08 22:45 ` [PATCH 01/19] lvm2app: Add thin and thin pool lv creation V4 Tony Asleson
2013-05-08 22:45 ` [PATCH 02/19] lvm2app: Implementation of pv resize (v6) Tony Asleson
2013-05-08 22:45 ` [PATCH 03/19] lvm2app: Move percent_of_extents to lvm-percent.[h|c] Tony Asleson
2013-05-08 22:45 ` [PATCH 04/19] lvm2app: Rework argument handling for lv resize Tony Asleson
2013-05-08 22:45 ` [PATCH 05/19] lvm2app: Move core lv re-size code (v2) Tony Asleson
2013-05-09  7:13   ` Zdenek Kabelac [this message]
2013-05-09 13:55     ` Tony Asleson
2013-05-08 22:45 ` [PATCH 06/19] lvm2app: Implement lv resize (v2) Tony Asleson
2013-05-08 22:45 ` [PATCH 07/19] lvm2app: Add function to retrieve list of PVs Tony Asleson
2013-05-08 22:45 ` [PATCH 08/19] lvm2app: Implement lvm_pv_remove Tony Asleson
2013-05-08 22:45 ` [PATCH 09/19] python-lvm: Add bindings for lvm_pv_remove Tony Asleson
2013-05-08 22:45 ` [PATCH 10/19] lvm2app: Set suppress to 1 Tony Asleson
2013-05-08 22:45 ` [PATCH 11/19] _get_pvs: Remove unused variable Tony Asleson
2013-05-08 22:45 ` [PATCH 12/19] lib2app: Fix warnings in lvm_list_pvs_free Tony Asleson
2013-05-08 22:45 ` [PATCH 13/19] lib2app: Added PV create Tony Asleson
2013-05-08 22:45 ` [PATCH 14/19] python-lvm: Add pvCreate python method Tony Asleson
2013-05-08 22:45 ` [PATCH 15/19] lvm2app: Add method to retrieve attr from lv Tony Asleson
2013-05-08 22:45 ` [PATCH 16/19] python-lvm: Add method to retrieve lv attr Tony Asleson
2013-05-08 22:45 ` [PATCH 17/19] lvm2app: Add function to retrieve the origin Tony Asleson
2013-05-08 22:45 ` [PATCH 18/19] python-lvm: Added lv method getOrigin Tony Asleson
2013-05-08 22:45 ` [PATCH 19/19] python-lvm: Bindings for thin pool, thin lv creation V3 Tony Asleson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518B4C96.5020601@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.