All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Kazior <michal.kazior@tieto.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [RFT] ath10k: retry target reset
Date: Thu, 9 May 2013 09:22:37 +0200	[thread overview]
Message-ID: <518B4EBD.1080703@tieto.com> (raw)
In-Reply-To: <87sj1wy71p.fsf@kamboji.qca.qualcomm.com>

On 09/05/13 08:57, Kalle Valo wrote:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> Sometimes the device just won't reset cleanly
>> without retrying. This seems to depend on the host
>> hardware.
>>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>> ---
>>
>> I can't reproduce the issue on my hw. Can someone
>> confirm if this fixes the problem?
>
> If you are referencing to the crash I reported to you privately, I have
> seen that problem only once and haven't been able to reproduce since. So
> I can't really test this patch.

Yes. This is both fortunate, and unfortunate :) The patch is actually my 
best guess what that issue might've been related to.


> You have same warnings messages in different places now. I recommend
> adding "..for start" and "...for reset", or something like that, to
> exactly identify the warning location. Example:
>
> ath10k_warn("target did not wake up for reset\n");

Good catch. Thanks!


-- Pozdrawiam / Best regards, Michal Kazior.

  reply	other threads:[~2013-05-09  7:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87wqrhcqxq.fsf@kamboji.qca.qualcomm.com>
2013-05-06  7:33 ` [ath9k-devel] [PATCH] ath10k: avoid infinite loop Michal Kazior
2013-05-07 14:00   ` Kalle Valo
2013-05-06  7:47 ` [ath9k-devel] [RFT] ath10k: retry target reset Michal Kazior
2013-05-09  6:57   ` Kalle Valo
2013-05-09  7:22     ` Michal Kazior [this message]
2013-05-09  8:27       ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518B4EBD.1080703@tieto.com \
    --to=michal.kazior@tieto.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.