From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
Cc: gleb@redhat.com, pbonzini@redhat.com, mtosatti@redhat.com,
kvm@vger.kernel.org
Subject: Re: [PATCH 2/3] KVM: MMU: Use kvm_mmu_sync_roots() in kvm_mmu_load()
Date: Thu, 09 May 2013 18:18:45 +0800 [thread overview]
Message-ID: <518B7805.7040702@linux.vnet.ibm.com> (raw)
In-Reply-To: <20130509154512.117fbfd9.yoshikawa_takuya_b1@lab.ntt.co.jp>
On 05/09/2013 02:45 PM, Takuya Yoshikawa wrote:
> No need to open-code this function.
>
> Signed-off-by: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
> ---
> arch/x86/kvm/mmu.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
> index 08119a8..d01f340 100644
> --- a/arch/x86/kvm/mmu.c
> +++ b/arch/x86/kvm/mmu.c
> @@ -3761,9 +3761,7 @@ int kvm_mmu_load(struct kvm_vcpu *vcpu)
> if (r)
> goto out;
> r = mmu_alloc_roots(vcpu);
> - spin_lock(&vcpu->kvm->mmu_lock);
> - mmu_sync_roots(vcpu);
> - spin_unlock(&vcpu->kvm->mmu_lock);
> + kvm_mmu_sync_roots(vcpu);
Reviewed-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
next prev parent reply other threads:[~2013-05-09 10:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 6:43 [PATCH 0/3] KVM: MMU: Simple mmu cleanups Takuya Yoshikawa
2013-05-09 6:44 ` [PATCH 1/3] KVM: MMU: Clean up set_spte()'s ACC_WRITE_MASK handling Takuya Yoshikawa
2013-05-09 10:16 ` Xiao Guangrong
2013-05-09 11:18 ` Gleb Natapov
2013-05-09 12:16 ` Xiao Guangrong
2013-05-10 1:33 ` Takuya Yoshikawa
2013-05-09 6:45 ` [PATCH 2/3] KVM: MMU: Use kvm_mmu_sync_roots() in kvm_mmu_load() Takuya Yoshikawa
2013-05-09 10:18 ` Xiao Guangrong [this message]
2013-05-12 11:53 ` Gleb Natapov
2013-05-09 6:46 ` [PATCH 3/3] KVM: MMU: Consolidate common code in mmu_free_roots() Takuya Yoshikawa
2013-05-09 10:11 ` Xiao Guangrong
2013-05-10 1:05 ` Takuya Yoshikawa
2013-05-10 1:43 ` Xiao Guangrong
2013-05-13 11:24 ` Gleb Natapov
2013-05-13 13:02 ` Xiao Guangrong
2013-05-13 13:20 ` Takuya Yoshikawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518B7805.7040702@linux.vnet.ibm.com \
--to=xiaoguangrong@linux.vnet.ibm.com \
--cc=gleb@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=yoshikawa_takuya_b1@lab.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.