From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 10/8] xfsdb: re-instate DA btree node headers
Date: Thu, 09 May 2013 10:23:24 -0500 [thread overview]
Message-ID: <518BBF6C.2000101@sgi.com> (raw)
In-Reply-To: <20130501063006.GK10481@dastard>
On 05/01/13 01:30, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> When removing the dirv1 code, it wasn't immediately obvious that the
> dir v2 code used a small chunk of the dirv1 field definitions. i.e.
> those for the DA btree node headers. Hence bits of xfs_db didn't
> work as expected, and some tests failed in non-obvious ways. e.g
> test 073 failed with this additional line of output:
>
> Use of uninitialized value $logstart in numeric gt (>) at /home/dave/src/xfstests-dev/src/fill2fs line 84
>
> which was the result of the command:
>
> xfs_db -r -c sb -c $TEST_DEV
>
> giving an unexpectedly incorrect output.
>
> Re-instate the needed field definitions and rename them from "DIR"
> to "DA" so it is obvious they are for decoding DA Btree format
> blocks.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---
This no longer cleanly applies.
--Mark.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-09 15:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20130430121300.GB10481@dastard>
2013-05-01 0:17 ` [PATCH 9/8] libxlog: fix log buffer alignment Dave Chinner
2013-05-09 15:07 ` Mark Tinguely
2013-05-01 6:30 ` [PATCH 10/8] xfsdb: re-instate DA btree node headers Dave Chinner
2013-05-09 15:23 ` Mark Tinguely [this message]
2013-05-09 16:21 ` Mark Tinguely
2013-05-01 6:31 ` [PATCH 11/8] xfs_logprint: fix continuation transactions Dave Chinner
2013-05-09 14:59 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518BBF6C.2000101@sgi.com \
--to=tinguely@sgi.com \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.