All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kbuild@01.org, Kyungmin Park <kyungmin.park@samsung.com>,
	Julia Lawall <julia.lawall@lip6.fr>,
	LMML <linux-media@vger.kernel.org>
Subject: Re: [kbuild] [linuxtv-samsung:next/exynos-is 3/17] drivers/media/media-entity.c:477:1-11: second lock on line 479
Date: Fri, 10 May 2013 11:19:30 +0200	[thread overview]
Message-ID: <518CBBA2.7020905@samsung.com> (raw)
In-Reply-To: <20130509232644.GI30128@mwanda>

On 05/10/2013 01:26 AM, Dan Carpenter wrote:
> Hi Sylwester,
> 
> FYI, there are coccinelle warnings in

Thanks a lot for this bug report. I've just re-tested the patch
and the bug is evident there, looks like it was introduced in
a "last minute" changes and the test environment wasn't updated
properly. The corrected patch to follow.

Regards,
Sylwester

> tree:   git://linuxtv.org/snawrocki/samsung.git next/exynos-is
> head:   90029a2ca496f71ba629ea932ac761e16f4e823b
> commit: cae9aa2c7b182d1b687196292059bca2f2cedf0f [3/17] media: Add function removing all media entity links
> 
>>> drivers/media/media-entity.c:477:1-11: second lock on line 479
> --
>>> drivers/media/media-entity.c:477:1-11: second lock on line 479
> 
> git remote add linuxtv-samsung git://linuxtv.org/snawrocki/samsung.git
> git remote update linuxtv-samsung
> git checkout cae9aa2c7b182d1b687196292059bca2f2cedf0f
> vim +477 drivers/media/media-entity.c
> 
> cae9aa2c Sylwester Nawrocki 2013-05-08  471  
> cae9aa2c Sylwester Nawrocki 2013-05-08  472  void media_entity_remove_links(struct media_entity *entity)
> cae9aa2c Sylwester Nawrocki 2013-05-08  473  {
> cae9aa2c Sylwester Nawrocki 2013-05-08  474  	if (WARN_ON_ONCE(entity->parent == NULL))
> cae9aa2c Sylwester Nawrocki 2013-05-08  475  		return;
> cae9aa2c Sylwester Nawrocki 2013-05-08  476  
> cae9aa2c Sylwester Nawrocki 2013-05-08 @477  	mutex_lock(&entity->parent->graph_mutex);
> cae9aa2c Sylwester Nawrocki 2013-05-08  478  	__media_entity_remove_links(entity);
> cae9aa2c Sylwester Nawrocki 2013-05-08 @479  	mutex_lock(&entity->parent->graph_mutex);
> cae9aa2c Sylwester Nawrocki 2013-05-08  480  }
> cae9aa2c Sylwester Nawrocki 2013-05-08  481  EXPORT_SYMBOL_GPL(media_entity_remove_links);
> cae9aa2c Sylwester Nawrocki 2013-05-08  482  
> 
> ---
> 0-DAY kernel build testing backend              Open Source Technology Center
> http://lists.01.org/mailman/listinfo/kbuild                 Intel Corporation
> _______________________________________________
> kbuild mailing list
> kbuild@lists.01.org
> https://lists.01.org/mailman/listinfo/kbuild

           reply	other threads:[~2013-05-10  9:19 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20130509232644.GI30128@mwanda>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518CBBA2.7020905@samsung.com \
    --to=s.nawrocki@samsung.com \
    --cc=dan.carpenter@oracle.com \
    --cc=julia.lawall@lip6.fr \
    --cc=kbuild@01.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.