From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Egger <chegger@amazon.de>
Subject: Re: [PATCH] docs: make 'gmake dist-docs' work
Date: Fri, 10 May 2013 14:06:05 +0200
Message-ID: <518CE2AD.60007@amazon.de>
References: <51752547.70801@amazon.de>
	<1366804085.20256.290.camel@zakaz.uk.xensource.com>
	<5177D5EF.5040908@amazon.de>
	<1366808536.20256.345.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1366808536.20256.345.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 24.04.13 15:02, Ian Campbell wrote:
> On Wed, 2013-04-24 at 13:54 +0100, Christoph Egger wrote:
>> On 24.04.13 13:48, Ian Campbell wrote:
>>> On Mon, 2013-04-22 at 12:55 +0100, Egger Christoph wrote:
>>>> doc: Makefile fixes
>>>>     
>>>> - use correct pathes (make gmake dist-docs from toplevel directory work)
>>>> - use tools as found by configure (perl)
>>>
>>> Did you test this?
>>
>> Yes.
> 
> Against unstable?

yes.

> 
>> [...]
>>
>>> $(PERL) is defined in config/Tools.mk but docs/Makefile by design only
>>> includes config/Docs.mk. I think you need to check for perl in
>>> docs/configure.ac as well and propagate the result into config/Docs.mk
>>>         AC_ARG_VAR([PERL], [Path to Perl parser])
>>>         AX_PATH_PROG_OR_FAIL([PERL], [perl])
>>
>> docs/Makefile also includes Config.mk which in turn includes
>> config/Tools.mk.
> 
> Not here it doesn't:
>         $ git show --oneline
>         0a97f68 install qemu into the location specified via configure --prefix.
>         ...
>         $ grep Tools.mk Config.mk 
>         $
>         $ grep include Config.mk 
>         -include $(XEN_ROOT)/.config
>         include $(XEN_ROOT)/config/$(XEN_OS).mk
>         include $(XEN_ROOT)/config/$(XEN_TARGET_ARCH).mk
>         EXTRA_INCLUDES += $(EXTRA_PREFIX)/include
>         $
>         $ rgrep -l Tools.mk *
>         tools/config.status
>         tools/Makefile
>         tools/Rules.mk
>         tools/configure.ac
>         tools/config.log
>         tools/configure
> 
> Perhaps you have some other local patches?

Yes. Just submitted with subject
'[Xen-devel] [PATCH] Make sure to use tools as found by configure'.

Christoph