Re: [PATCH] clarify network drive description

["Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1893 bytes --]

On 09.05.2013 16:31, Andrey Borzenkov wrote:

> Mention that network drives can include server address and that
> necessary modules are not autoloaded and must be loaded manually. Also
> cross-reference to net_default_server.
> 
> Signed-off-by: Andrey Borzenkov <arvidjaar@gmail.com>
> 
> ---
>  ChangeLog      | 5 +++++
>  docs/grub.texi | 9 ++++++---
>  2 files changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index 33d1265..d661157 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2013-05-09  Andrey Borzenkov <arvidjaar@gmail.com>
> +
> +	* docs/grub.texi (Device syntax): Clarify description of network
> +	drives.
> +
>  2013-05-08  Andrey Borzenkov <arvidjaar@gmail.com>
>  
>  	* docs/grub.texi (Network): Add description of net_default_interface,
> diff --git a/docs/grub.texi b/docs/grub.texi
> index 70c0de8..95b74d8 100644
> --- a/docs/grub.texi
> +++ b/docs/grub.texi
> @@ -2531,9 +2531,12 @@ of the partition when installing GRUB).
>  (hd0,1,3)
>  @end example
>  
> -If you enabled the network support, the special drives @samp{(tftp)},
> -@samp{(http)} and so on ars also available.
> -Before using the network drive, you must initialize the network.
> +If you enabled the network support, the special drives
> +@code{(@var{protocol}[,@var{server}])} are also available. Supported protocols
> +are @samp{http} and @samp{tftp}. If @var{server} is omitted, value of
> +environment variable @samp{net_default_server} is used.
> +Note that necessary modules (@samp{http} and @samp{tftp}) have to be loaded
> +manually. Before using the network drive, you must initialize the network.

I've changed it: now http/tftp are autoloaded but you still need network
interface module (pxe/ieee1275_net/...) loaded manually.
Can you please adjust this patch to this improvement and commit?


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]